gpl: fix NVCC errors by refactoring old-style OpenMP loops#10984
Open
SquareRobin wants to merge 2 commits into
Open
gpl: fix NVCC errors by refactoring old-style OpenMP loops#10984SquareRobin wants to merge 2 commits into
SquareRobin wants to merge 2 commits into
Conversation
Signed-off-by: Igor Sokolov <disk.destroyer@yahoo.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modernizes several loops in nesterovBase.cpp by replacing old-style iterator loops with range-based for loops compatible with modern OpenMP. The feedback suggests a safer and more consistent way to calculate the index of an element in a contiguous container using .data() instead of dereferencing the first element of a potentially empty vector.
Signed-off-by: Igor Sokolov <disk.destroyer@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Iterator-based loops cause compile-time errors if GPU acceleration via CUDA (even the latest 13.3.1 is affected) is enabled. Using the newer range-based loops fixes this.
Type of Change
Impact
No runtime impact.
Verification
./etc/Build.sh).