maths: add weighted_average function#14850
Open
liyana3572 wants to merge 1 commit into
Open
Conversation
mindaugl
approved these changes
Jun 23, 2026
zuhairkazmi14
left a comment
There was a problem hiding this comment.
The implementation is clean and follows PEP8 style conventions perfectly. The inclusion of doctests for empty lists, mismatching lengths, and zero-sum weights is excellent. One minor optimization: instead of if not values and not weights:, since you check length mismatch immediately after, you could simplify this by checking if the values list is empty first: if not values: raise ValueError('Inputs cannot be empty'). This is cleaner and correctly catches empty lists even if one of them was passed with elements. Otherwise, great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a weighted_average function to maths/weighted_average.py that computes the weighted arithmetic mean of a list of values given corresponding weights, with input validation.
Checklist: