Skip to content

sorts: type double_sort for any comparable items - #15341

Closed
itsnevu wants to merge 1 commit into
TheAlgorithms:masterfrom
itsnevu:sorts/double-sort-comparable
Closed

itsnevu wants to merge 1 commit into
TheAlgorithms:masterfrom
itsnevu:sorts/double-sort-comparable

Conversation

@itsnevu

@itsnevu itsnevu commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Describe your change

Makes double_sort generic over any Comparable items instead of list[Any], following the already-merged insertion_sort.py pattern (a Comparable Protocol plus a [T: Comparable] type parameter). Comparisons already go through < only, so items only need __lt__.

Part of #15234 (using "Part of", not a closing keyword, so the umbrella issue stays open).

  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing. New doctests cover a str list, a float/int mix, and a pytest.raises(TypeError) for non-comparable input.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 15, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@itsnevu, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant