Repository navigation
sorts: type patience_sort's Stack for any comparable item - #15427
Merged
Merged
Conversation
Member
|
ON HOLD: Our focus is on merging or closing old pull requests before October 1st. Only do one or two of these solutions so others have a chance to learn how these type hints work. |
This was referenced Sep 24, 2026
priya-sundaram-dev
approved these changes
Sep 24, 2026
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
LGTM ✅ Verified locally: doctests pass. Stack.__lt__ uses < (good). Stack.__eq__ uses ==, which falls back to object.__eq__ for a __lt__-only type — harmless, and bisect only needs <. Ready to merge.
cclauss
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15234.
Describe your change
Checklist