Add optional PKCE support for OAuth2 - #494
Open
EnzoCyberSec wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request is about adding PKCE support to the OAuth2 authentication flow. We talked about this in the issue.
Nowadays Identity Providers are starting to require PKCE to stop authorization code interception attacks. This new feature makes sure Cortex can work well with these secure Single Sign-On environments.
To make sure everything works with the system this feature is turned off by default. You can turn it on by changing the
application.conffile.Changes made
Configuration: I added a flag to
OAuth2Configthat you can find inauth.oauth2.pkce. This flag is set tofalseby default.Authorization Request: If
pkceis turned on the code makes acode_verifier. Stores it in the session. It also addscode_challengeandcode_challenge_method=S256to the Single Sign-On URI.Token Request: If there is a
code_verifierin the session it gets added to the POST payload so we can get the access token.How to use
Administrators just need to add this line to their
application.conffile inside the block:pkce = trueRelated Issue
This resolves issue #493