feat: Response header access, settable timeouts, strict typing - #4
Open
joramkruijer wants to merge 4 commits into
Open
joramkruijer wants to merge 4 commits into
joramkruijer wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoREST now requires php >= 8.1, which enabled the adding of strict typing.
This merge also introduces a quite a few changes and improvements:
$client->getLastResponseHeaders(), and in the exceptions by callinggetResponseHeaders()on the caught exception$client->setTimeout(60), or directly when constructing a new client:new Client(...)->setTimeout(60). To set a different TLS handshake timeout as well:$client->setTimeout(60, 10). The default timeouts are 30s for the overall request, and 10s for TLS handshakes.content-typein a response will no longer throw anInvalidArgumentException: instead the body is returned as-is, without any decoding being attemptedtext/plain, or a non-array/object payload with content-typeapplication/x-www-form-urlencodedwill throw anInvalidArgumentExceptionpost()/put()/patch()is sent as-is regardless of content type. We assume the caller has already encoded strings passed to these functions: simply pass an array or object to have it encoded automatically.[]or a headers array that omits it entirelyFor development:
phpstan/phpstan,squizlabs/php_codesnifferand their respective config files.