Migrate events/cantcreate page to Vue + i18n (Group 5.2)#867
Open
edwh wants to merge 4 commits into
Open
Conversation
Purely presentational page shown when a restarter (or host with no
groups) hits /party/create. Moves hard-coded English text into
lang/{en,fr,fr-BE}/cantcreate.php and renders via a Vue component.
Adds a feature test asserting the Vue mount renders.
|
a_host_without_a_group_cant_create_an_event asserted the server-rendered string "You need to be a host of a group ...", but that copy now lives in the CantCreateEventPage Vue component (cantcreate.intro, rendered client-side). Assert the component mount instead, matching CantCreateEventPageTest. Verified: CreateEventTest + CantCreateEventPageTest green (20 tests, 271 assertions).
A static `src="/images/dashboard/..."` in CantCreateEventPage.vue made Vite/Rollup
try to resolve the public image as a build-time import and fail
("Rollup failed to resolve import"), breaking `vite build` (and thus the
Playwright CI step). Bind it as `:src="'/images/...'"` — a runtime string, the
same pattern used by GroupDeviceRepairPodium.vue — so Vite leaves it untouched.
Verified: `vite build` exits 0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan