Repository navigation
Commit e109361
Send a JSON body when Enter chat starts a face room (#1098)
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1085
## What changed
Enter chat calls `POST /v1/face-rooms/:id/start` with no body. On
https://social.botawaken.com that request is HTTP 500 `{ code:
"internal_error", message: "internal error" }` before auth, and the
waiting dialog shows that string. The same POST with `{}` reaches the
handler. Face-room POST, PUT, and PATCH calls that omit a body now send
`{}`.
Docs-not-needed: the face-room request body is not an architecture
change.
## Verification at the tip
Tip SHA: 5eee4ac
Fail-without-change: on the unbroken tip, `node --import
./test/resolve.mjs --test --test-name-pattern '#1085'
test/face-rooms.test.js` in plugins/social failed with message "internal
error" (code internal_error). After the callHttp change the same test
passes.
Ran: `TZ=UTC npm run verify` (exit 0). core lint and arch-docs OK;
plugins lint OK; client.js check OK; 10 patches apply; core equals
ds-bot + patches. core tests 1439 pass / 0 fail; social 476 pass / 0
fail (includes #1085); tree 125 pass / 0 fail; timeline 125 pass / 0
fail; .github/scripts 417 pass / 0 fail; interop 37 pass / 0 fail;
live-e2e 16 pass / 0 fail. After the commit, `node
core/scripts/check-arch-docs.mjs` reported OK (3 changed files) and
`node .github/scripts/changelog.mjs check` reported the fragments well
formed.
Not run: smoke (no core/index.js or src/host change). Desktop. A live
face room on Social (the production probe was unauthenticated: a
bodyless POST /start returned 500 internal error, and the same POST with
`{}` returned 401 and reached the handler).
## Self-review note
Implementer only. No Verdict. PASS and enqueue stay with the
coordinator.
Not enqueued.
<!-- CURSOR_AGENT_PR_BODY_END -->
<div><a
href="https://cursor.com/agents/bc-aeb772ba-58a9-5608-80d1-a141c5b7f233?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a
href="https://cursor.com/background-agent?bcId=bc-aeb772ba-58a9-5608-80d1-a141c5b7f233&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>1 parent 24d306b commit e109361
3 files changed
Lines changed: 33 additions & 2 deletions
File tree
- changelog.d
- plugins/social
- src
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
706 | 706 | | |
707 | 707 | | |
708 | 708 | | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
709 | 715 | | |
710 | 716 | | |
711 | 717 | | |
712 | 718 | | |
713 | 719 | | |
714 | 720 | | |
715 | | - | |
| 721 | + | |
716 | 722 | | |
717 | | - | |
| 723 | + | |
718 | 724 | | |
719 | 725 | | |
720 | 726 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
439 | 439 | | |
440 | 440 | | |
441 | 441 | | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
442 | 466 | | |
443 | 467 | | |
444 | 468 | | |
| |||
0 commit comments