Skip to content

First-time 6-digit create path looks like an error (Join then Start a new room) #1053

Closed

Description

@Birfy

Reproduce

Two fresh FlyBot homes on main b9a66e1 (SelfA1025 :3090 / SelfB1025 :3091 → https://47-80-69-220.sslip.io):

  1. On A, open + → Join or create by number or link (title promises both join and create).
  2. Pick Chief, enter a fresh 6-digit code unused by anyone nearby (e.g. 582914).
  3. Click the primary button Join.

Expected

First entrant can create the room in one clear step, or Join/Create wording matches the two-step flow (no "error-shaped" waiting copy if create is intended).

Actual

  • Primary button always says Join even when the dialog title is "Join or create…".
  • After Join on a fresh code: copy like "Nobody is waiting under 582914…" then the user must click "Start a new room".
  • First create looks like a failed join / empty search rather than a happy path.

Environment

  • SHA: b9a66e1e87133b3771ee63f01204c3546fee5490
  • Homes: SelfA1025 / SelfB1025 (fresh)
  • Social: https://47-80-69-220.sslip.io

Screenshots (on box; not uploaded)

  • /workspace/social-ui-deep-test/shots/08-A-join-or-create.png — join-or-create dialog / surrounding shell before or around the create path.
  • /workspace/social-ui-deep-test/shots/10-A-room-waiting.png — post-Join waiting / "Nobody is waiting…" + Start a new room step for code 582914.

Suggested scope

Needs a product decision before implementation:

  1. One-step Create — if no one is under the code, primary action creates immediately (button may become "Create room" when the code is free), or
  2. Keep Join-then-Start — but retitle/reword so it does not read as an error (e.g. "No one here yet — start the room?" with a positive primary).

Please pick (1) or (2) in a comment; then this can flip to agent-ready.

Source

product UI deep-test 2026-10-25

Activity

  1. added
    enhancementNew feature or request
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    area:socialFriends, invites, grants, Bot Social
    area:uiWeb/desktop UI and copy
    self-testFiled by the product self-test routine (issues only)
    on Oct 25, 2026
  2. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Needs-human: please pick the create-path product rule before this can flip to agent-ready.

    1. One-step Create — free 6-digit code creates the room immediately (button may read "Create room" when free), or
    2. Keep Join-then-Start — but retitle/reword so "Nobody is waiting…" does not read as a failed join.

    Filed by product UI deep-test 2026-10-25; not claimed.

  3. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Owner decision (recorded by Birfy): Prefer one clear primary path for a fresh number.

    When nobody is waiting under the code, the primary action should be Start a new room (or Join should create when empty) — not an error-looking “Nobody is waiting” screen as the main path. Keep the informative copy if useful, but don’t make first create feel like a failure.

    i18n: English + Chinese.

    Claimed by Birfy. Branch: birfy/fix/1053-face-first-create-path, from main (will sync to tip). Flipping needs-human → agent-ready + agent-working.

    Written-by: Birfy

  4. added
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    and removed
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Oct 25, 2026
  5. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Closing for now per owner: findings not yet re-verified against social.botawaken.com. Will reopen only if confirmed on a fresh UI pass.

  6. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Closing at owner's request pending re-verification on social.botawaken.com — these findings may be false positives and are not yet confirmed.

  7. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 25, 2026
  8. 4 remaining items

  9. self-assigned this
    on Oct 25, 2026
  10. removed
    bugSomething isn't working
    on Oct 25, 2026
  11. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Owner decision (2026-10-25): one clear create path — when nobody is waiting, "Start" should be the primary action rather than Join-then-error. Confirmed on reverify2 with code 846271: first-time 6-digit create still reads as an error. Reopening; claimed by Birfy.

  12. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 25, 2026
  13. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    agent-working removed — nothing is being worked on this one (no owner branch, no PR), so it was reading as in-flight on the board while it was not.

    The repro is on main b9a66e1, which is now four merges behind c062fb02. Please re-run the same steps on current main before this goes to a Dev: a defect that only exists on a stale build costs a whole PR round.

    Labels stay as they are if the re-run reproduces. If it does not, close it or move it to needs-info with what changed.

  14. added
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 25, 2026
  15. added a commit that references this issue on Oct 25, 2026
    f3ec216
  16. added a commit that references this issue on Oct 25, 2026
    0e9dbbb
  17. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 25, 2026
  18. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    done — four checks on 2ce0e7f1 (current main, merge of #1075 @ 2da964fd):

    1. #1053 closed/completed; Fixes #1053 → #1075 merged: true, merge commit 2ce0e7f1.
    2. changelog.d/1053-face-first-create.changed.md on main (341 B).
    3. Docs on main: docs/subsystems/social.md — “The dialog primary line is Start a new room with … and its primary button, listed first, is Start a new room (start: true adopts the held room through GET, no second create, First-time 6-digit create path looks like an error (Join then Start a new room) #1053) … The line does not read as a failed join.” One row in docs/subsystems/core-client.md.
    4. Code on main: plugins/social/client.js has const NOBODY_TITLE = 'Start a new room with {code}', const START_NEW_ROOM and the face-nobody-title node; the four i18n lines are in core/src/client/i18n.js and in 0001/0008.

    Labels: agent-working off this issue, agent-pr off #1075; agent-ready left for Triage.

  19. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:socialFriends, invites, grants, Bot Socialarea:uiWeb/desktop UI and copyenhancementNew feature or requestself-testFiled by the product self-test routine (issues only)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions