Repository navigation
Hide internal tool-registration lines in the chat - #1105
Merged
Merged
Conversation
DSH writes a tool-addition row when a session's request header gains a tool. A plain turn was printing that row for track_tasks and track_links. ContextCell now drops those rows for the team tools and track_links. Fixes #1101 Co-authored-by: Danyang Chen <birfychen@gmail.com>
Collaborator
Author
|
Verdict: PASS at 743796c Fixes #1101. Plain chat turns no longer render DSH tool-registry rows for team tools (and Ran:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1101
What changed
A plain chat turn printed DSH's tool-registry rows as
Tool added: track_tasksandTool added: track_links.ContextCell(core/src/client/cells.js) now dropsTool added/Tool removedfor every team tool and fortrack_links. A tool a person turns on (web_search,bash) still shows. A call the Bot actually makes stays a tool cell.track_linksis not registered in this tree or in DSH 0.2.0-rc.2. It was the notice on the other home of the report, so the same hide covers that name. The class is the product's own registration notices: the test walks everyTEAM_TOOLSname.Verification at the tip
Tip SHA:
743796cd22c8bb830b7d5d74097b6bfff4507fcfFail-without-change: defect test. On base
b77f744, before the source change,node --import ./test/harness-resolve.mjs --test test/hidden-tool-removal.test.jsincore/failed#1101atlist_bots(false !== true): a team tool'stool-additionrow still rendered. The same command at this tip passes 4/4.Ran:
$ TZ=UTC npm run verify
pass. core lint (oxlint + arch-docs OK, 7 changed files), plugin lint,
build-client.mjs --check,ds-bot-patches.mjs check(10 patches), core tests 1443 pass / 0 fail, social 476 pass, tree 125 pass, timeline 125 pass,.github/scripts417 pass, interop 37 pass, live-e2e 16 pass.Not run: smoke bench (
index.jsandsrc/host/unchanged). No changelog fragment and no version bump.No Verdict.