Skip to content

Co-seat shared-group Bot outbound still waits for owner Approve #1175

Open

Description

@Birfy

Symptom

E2E 2026-10-25 Asia/Shanghai on box FlyBot :3090/:3091 vs prod Social: ordinary shared group with Friend's Bot on the other home.

Human lines from B's Bot path showed Waiting for approval until B clicked Approve; A's outbound to B's Bot also needed Approve. Owner expectation from earlier: once Bots share a live group/room, they should message without separate friendship/Sharing friction (「拉了群就应该都能发消息」).

Related prior work: #1145 co-member messaging; #1122/#1117 Auto-send clears. This may be a remaining blanket outbound / pair Auto-send gap for Friend's Bot seats.

Claim

Claimed by Birfy / bot-im — will implement after #1174 merges unless overlapping.

Activity

  1. self-assigned this
    on Oct 25, 2026
  2. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    Re-triaged on main 97065bac: needs-info, because the report describes two very different situations with the same words, and the code distinguishes them:

    • Auto-send is off for that room — then a held line is by design. social.js:176-183 names face_room_auto_send_off as a real per-room switch, :4497 only auto-sends a face line when autoSendFaceLine succeeds, and :4510-4515 refuses unless held.autoSendHold === true. A pair that has never set it reads “Waiting for approval” forever, and the owner's Approve is the feature working.
    • A blanket hold that should have been cleared — autoSendRoomEnvelope clears the blanket mvp.all_outbound_requires_approval hold for a room line (:1825, :1867, :2000), and :181-182 says explicitly that neither outbound path clears face_room_auto_send_off. If the pair is a co-seat in one open room and the room's own Auto-send is on, a card here is a bug — in the clearing path, not in the seat.

    What I need on this issue to decide between them, all of it from the same attempt:

    1. the hold's holdReason and reasons (the face_room_auto_send_off switch versus a blanket reason);
    2. whether the room's own Auto-send switch reads on for the holding Bot, and for the other seat;
    3. which room (roomId) and whether both Bots are current members of that same open room — co-seat versus 1:1 is the axis Send a shared-room leave while the seat is still reachable #1174/Co-seat shared-group Bot outbound still waits for owner Approve #1175 turn on;
    4. whether the same pair, outside any room, also waits — if yes this is the 1:1 path (#948 territory), not the room path.

    With those four answered this becomes either “working as designed, set the room's Auto-send” (and closes) or an agent-ready bug with a named file. Labels: area:social added, because this is Bot Social outbound, not a UI defect.

  3. added
    area:socialFriends, invites, grants, Bot Social
    needs-infoWaiting for the reporter or a maintainer decision
    on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:socialFriends, invites, grants, Bot SocialbugSomething isn't workingneeds-infoWaiting for the reporter or a maintainer decision

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions