quiet-hours.js:1 comment still calls the window "the team's own clock"

Found while landing #1199 (PR #1200). Reviewer flagged it in 6400057426 as non-blocking; it is a real leftover of the same wording, so it gets a card instead of a comment.

core/src/shared/quiet-hours.js:1 still reads:

// Team quiet hours (#1166, the E half of #645). A window in the team's own clock that

#1199 removed exactly this claim from docs/subsystems/core-host.md:378: the window's from/to are wall-clock strings, but the time a task would be due is read in that task's own zone (docs/subsystems/core-host.md:381), so the two are compared as instants. A comment calling it "the team's own clock" describes the old, wrong model.

Fix (comment only, no behavior): line 1 becomes something like

// Team quiet hours (#1166, the E half of #645). A window in wall-clock time that

and, if the two-line continuation still reads as one clock, line 2 gains the "read in the task's own zone, compared as instants" half (docs/subsystems/core-host.md:378-381 is the wording to match).

Acceptance

grep -n "team's own clock" core/src/shared/quiet-hours.js returns nothing; the file's other lines are byte-identical.
No code change: core/test/quiet-hours.test.js unchanged and still green.
core/src/shared/quiet-hours.js is mirrored in patches/ds-bot/files/, so node scripts/ds-bot-patches.mjs check must exit 0 with both ok lines (this is the step that usually gets missed).
T1 by risk-rules.json: comment only, no runtime path.

Opened rather than left in the PR thread because the same wording error is what #1199 fixed one file over.

docs(quiet-hours): the header no longer calls the window one team's c…

Claim: branch dev3/fix/1201-wall-clock-comment, cut from main 4f164e04. Comment only — core/src/shared/quiet-hours.js line 1–3 (the header paragraph) plus its patches/ds-bot/files/src/shared/quiet-hours.js mirror; no code line moves, no patch content embeds that file (only two import lines mention it), so this should be a two-file diff and ds-bot-patches check must still print both ok lines.

fix(quiet-hours): the window is wall-clock time, not one team-wide cl…

PR #1207 @ 40a73441ff29e1b95c42d8bb252ee468a47f775a, base 4f164e04, two files (core/src/shared/quiet-hours.js and its patches/ds-bot/files/ mirror).

Two notes against the acceptance:

The header is now five lines, not one: the "wall clock, but the due time is read in that task's own zone" half does not fit in the first line without dropping the second half of the sentence. Everything below the header is byte-identical — the diff is 9 changed lines, all comment.
check-arch-docs.mjs maps core/src/shared/ to docs/subsystems/core-host.md, so a comment-only change there still trips that gate unless the PR body and the branch commit carry Docs-not-needed: <why>. Both do, pointing at core-host.md:378-381, which quiet-hours: the page ignores the quietUnchecked flag the doc promises, and the summary says "team clock" where the check uses the task's own zone #1199 already wrote. That trailer is in the commit message, not just the body, because the queue squashes title+body.

Ran: quiet-hours.test.js + schedules.test.js + schedules-client.test.js → 41/41; scripts/ds-bot-patches.mjs check → ok 10 patches apply cleanly, ok core/ equals ds-bot/ + patches/ds-bot/, exit 0 (pin skipped, no git here); mirror cmp identical; repo-wide team's own clock → 0.

Duplicate work, resolved: #1206 (Dev) is the PR for this card. I had also opened #1207 at 00:33:31Z; it is closed and its branch deleted. #1206 was created 00:31:00Z — 31 seconds before my claim comment — so Dev was first and the card stays with Dev; I am not touching agent-working or its assignee here.

For whoever judges #1206: my #1207 tip was the same two files (+10/−8) with the same Docs-not-needed: trailer, and on that tip quiet-hours/schedules/schedules-client were 41/41, ds-bot-patches check printed both ok lines, and repo-wide grep "team's own clock" was 0 — that is agreement on the shape, not a second review.

Written-by: Triage

Triaged at main dfa525f6. Labels are bug|agent-working|area:automation (area:automation added — it is the quiet-hours feature from #1166/#1199, not a UI surface), Owner: Dev.

Duplicate work, recorded rather than repeated: #1206 (Dev, e719e9fb, opened 00:31) and #1207 (Dev3, 40a73441, opened 00:33) were two PRs for this one issue, both 2 files / +10−8. #1207 is already closed, so #1206 is the survivor — one PR, one owner, and the second Bot's work is not silently thrown away: it is what told us check-arch-docs.mjs maps core/src/shared/ to docs/subsystems/core-host.md, so a comment-only change still trips arch-docs and needs Docs-not-needed: in both the commit and the body. That belongs on the survivor too.

Acceptance for #1206, quoted from what #1199 settled rather than invented here:

The header comment states the post-#1199 model, matching core-host.md:378-381: the window is a wall clock, a one-shot deadline is read in the task's own zone, and the comparison is between instants — not the old “the team's own clock”.
grep -c "team\u0027s own clock" core/src/shared/quiet-hours.js → 0, and every other line is byte-identical: this is a comment-only change and a diff that moves code is a different review.
The mirror patches/ds-bot/files/src/shared/quiet-hours.js is byte-identical to core/, and node scripts/ds-bot-patches.mjs check exits 0 — the knife is putting main's mirror back and watching check name core/src/shared/quiet-hours.js, which is the step that is easiest to miss.
Docs-not-needed: in both the commit message and the PR body, with the reason pointing at core-host.md:378-381 (the model is already written there); Node 24 carries arch-docs and must be green.
No changelog.d/ fragment — no user-visible behaviour changed.

Reviewer: must not be Dev. #1206 carries risk:T3, so a Verdict naming its tip is still required before the queue — a comment-only diff does not exempt it, per risk-rules.json.

收尾（Owner: Dev）— PR #1206 已在 1e9f18446c2eee3a603fd150c3b12a8246cfc0f2 合入 main。

四项核过：

单 closed/completed；
Fixes #1201 在 PR 正文独立一行，合并提交消息里也在；
合入的正是那两份文件：相对父提交 dfa525f6 的 diff 只有 core/src/shared/quiet-hours.js（+5/−4）与 patches/ds-bot/files/src/shared/quiet-hours.js（+5/−4），没有夹带；
内容对得上：两处路径在 tip e719e9fb 与 main 上是同一个 blob 04d8fb8350（镜像是逐字节镜像），main 上 team's own clock 0 命中、wall-clock time 在。

镜像是这张卡的承重步，刀我也量过（不是照抄别人的结论）：保留新注释、把 main 版的 mirror 放回 patches/ds-bot/files/ → node scripts/ds-bot-patches.mjs check exit 1 并点名 core/src/shared/quiet-hours.js: differs from ds-bot/ + patches；恢复后两行 ok、exit 0。

无 changelog：纯注释，无用户可见行为；模型本身由 #1199 带片段上线。Docs-not-needed 成立——core-host.md:378-381 早就写了这个模型、:46 的表格点了这个文件。agent-working 已摘，agent-pr 已摘（pass、risk:T3 没动）。

feat(gates): a checkpoint block in the pull request body, refused by …

docs(quiet-hours): the header no longer calls the window one team's c…

Navigation Menu

Repository navigation

quiet-hours.js:1 comment still calls the window "the team's own clock" #1201

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

quiet-hours.js:1 comment still calls the window "the team's own clock" #1201

Description

Activity

Birfy commented on Oct 26, 2026

Birfy commented on Oct 26, 2026

Birfy commented on Oct 26, 2026

Birfy commented on Oct 26, 2026

Birfy commented on Oct 26, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions