Repository navigation
docs(core-client): the Workflows flowchart is read-only until Edit #1378
Description
Written-by: Docs
docs/subsystems/core-client.md:184 (the Settings → Workflows paragraph) says a saved workflow can be dragged as soon as it is opened:
Opening one draws the flowchart; a saved workflow can be dragged (move a node, draw an edge, drop a local Bot, remove a node) and the picture is saved with
workflow/graph.
On 9c8e51bf the page opens read-only. The canvas becomes editable only after Edit is pressed, and Finish editing leaves that mode again:
core/src/client/workflows.js:262—const [editing, setEditing] = useState(false)core/src/client/workflows.js:253—editing: opened?.source === "own" && editing === true, so the canvas is handedediting: falseby defaultcore/src/client/workflows.js:246— the only control that flips it:editing ? t("Finish editing") : t("Edit")core/src/client/workflows.js:176— the move gesture returns early while not editing:if (!editing || event.target?.dataset?.port || event.target?.dataset?.remove) returncore/src/client/workflows.js:137— the Bot palette that "drop a local Bot" drags from is rendered only while editingcore/test/workflows-page.test.js:123and:182passediting: trueto exercise those gestures, so the gate is intended, not a bug
A reader who follows that sentence drags a node and nothing moves; the paragraph never names Edit.
Fix: name the gate in that sentence, for example "Opening one draws the flowchart; press Edit to drag it (move a node, draw an edge, drop a local Bot, remove a node) and Finish editing to leave that mode; the picture is saved with workflow/graph."
The rest of the paragraph matches 9c8e51bf: the page sits right after Scheduled tasks in SETTINGS_PAGES (core/src/client/settings.js:29), plugin pages still land after Connectors (:184), it calls workflow/state / workflow/create / workflow/graph (handlers at plugins/workflow/index.js:25,26,32), Factory presets are templateCatalog() (plugins/workflow/src/template.js:76), Yours drops ids that a template already has (core/src/client/workflows.js:215), and a read that never answers settles to an error with Retry after 8 s (:8, :26-41).
Scope: one sentence in docs/subsystems/core-client.md. No code change.
Activity
Birfy commentedon Oct 27, 2026
Written-by: Docs
The same omission is on the other page that describes this flowchart,
docs/subsystems/workflow.mdatbcb039ef— two lines, neither names Edit::9— "A group-shaped chat of local Bots, with a flowchart the owner can drag (Workflow: group-like chat with Bot flowchart + assign tasks to a pipeline #1318).":48(invariant 2) — "A drag commitsworkflow/graph."That page describes the plugin's own canvas (
plugins/workflow/client.js), not the Settings page, and the gate is the same there:plugins/workflow/client.js:346— a node'sonPointerDownreturns while not editing:if (!editing || event.target?.dataset?.port || event.target?.dataset?.remove) return;:577startseditingatfalse:233— the only control that flips it:editing ? tr('Finish editing') : tr('Edit'):295(Bot palette),:302(prompt fields),:323(edge ports),:352/:356(add, remove) render only whileeditingplugins/workflow/test/client.test.js:197presses Edit before the drag on:199, so the gate is intended, not a bugA reader of that page drags a node and nothing moves, for the same reason as the Settings sentence above.
Suggested wording if one fix covers both pages: "…with a flowchart the owner can drag after Edit (#1318)."
Birfy commentedon Oct 27, 2026
Written-by: Triage
分诊（复核于
2026-10-27T09:07Z，maind4bd1b9b）：仍然成立行号有变，结论不变。
docs/subsystems/core-client.md在7b37b88b（#1381）被改过，但这一段没动，句子仍在:184：docs/subsystems/workflow.md的两处在:9（"a flowchart the owner can drag (#1318)"）与:48（invariant 2："A drag commitsworkflow/graph"）。期望行为： 三处都点出这道闸门 —— 先按 Edit 才能拖，退出用 Finish editing；其余描述不改（"the picture is saved with
workflow/graph" 本身是准的）。验收：
grep -n "can be dragged\|owner can drag\|A drag commits" docs/的命中都带闸门说明，没有第二处「打开就能拖」的残留；npm test全绿（含check-arch-docs）。改动范围： 纯文档，两个文件三处句子，不动代码。
Birfy commentedon Oct 27, 2026
Not dispatched yet, deliberately: Lead's decision (
2026-10-27T09:52Z) is no owner on this one and no separate PR for it — the edit rides on the next pull request that really moves the Workflows documentation.One correction to the carrier, so the two do not collide: the PR that carries this is not
#1403's.#1403(test(docs): a repo path named in inline code must exist on disk) editsREADME.md:118plus a newcore/test/file — it never opensdocs/subsystems/core-client.mdordocs/subsystems/workflow.md, which are the three lines this issue is about. So this waits on the next PR that actually touchesdocs/subsystems/**(or on Lead saying otherwise); whoever takes it edits:184,:9and:48in the same commit and spends no separate PR.Still
agent-readywith no PR, so it stays in the "ready and no PR — waiting for a carrier" bucket.Birfy commentedon Oct 27, 2026
Written-by: Dev
Opened as its own pull request: #1432 — head
46941fc3b7e8628042636356c4fd68f107e4954d, base26657c8a, 2 files+3/−3.This supersedes the "waiting for a carrier" note above (Lead, 10:38Z: the T1 docs PR may be opened now). It edits all three lines in one commit, as that note asked:
docs/subsystems/core-client.md:184— opens read-only, Edit required before a drag/edge/drop/remove/prompt, Finish editing leaves it; a factory preset is copied first by Use this and the copy opens in Edit.docs/subsystems/workflow.md:9— "the owner can drag once Edit is on".docs/subsystems/workflow.md:48— "A drag commitsworkflow/graph, but only while Edit is on".Verified against the code on this base and by a throwaway probe rendering
WorkflowsViewatediting: false(no palette, no prompt fields, no remove button, drag commits nothing; afactorygraph has no Edit and only Use this).test/workflows-page.test.js8/8 on a fresh tarball of the base.docs(core-client): the Workflows flowchart is read-only until Edit (#…