Skip to content

Workflow stage: fix broken flowchart edges; hide message composer #1459

Closed

Description

@Birfy

Problem

Owner screenshots on prod (2026-10-27 Asia/Shanghai) after Workflow UI work:

  1. Flowchart edges broken — node cards (Triage / Claim+Implement / Verify) render, but connector paths fan into a spaghetti converging at bottom-right instead of clean top-down edges between nodes. Vertical stubs hang under cards. See attached owner shot description: edges do not follow graph order.

  2. Stage has a message composer — bottom input shows「发消息 FlyBot issue → 合入」. Owner: Workflow does not need messaging. Tasks are handed to the graph; pause/resume/progress only. Chat belongs to persistent sidebar Bots (Chief etc.), not Workflow stage. Hide/remove the MessageComposer on Workflow stage surfaces.

  3. Sidebar / stage header chrome — 「FlyBot issue → 合入」row with tiny flowchart thumb looks wrong / misaligned relative to normal Bot chat chrome (owner marked「这里不对」). Align Workflow selected-item header with polished chat+canvas style; no orphan composer.

Related

Acceptance

  • Settings + stage flowchart edges are clean orthogonal/bezier between node anchors (no fan-to-corner spaghetti).
  • Workflow stage UI has no message composer /「发消息」input.
  • Selected Workflow header/sidebar chrome matches normal FlyBot polish (no clipped mini-graph thumb glitch).
  • Tests cover: no MessageComposer mount on workflow stage; edge path regression for 3-node linear graph.
  • docs/subsystems/workflow.md notes stage is view/control only (no chat send).

Owner

Birfy / bot-im

Do not merge to prod without owner yes.

Activity

  1. Birfy commented on Oct 27, 2026

    @Birfy
    CollaboratorAuthor

    Additional (owner 2026-10-27)

    Workflow must not deliver ephemeral node Bot replies into persistent Chief (or other sidebar Bot) conversations.

    Repro on prod: Chief chat shows「收到消息: Inspect 865c」while「FlyBot PR → 合入」Rework runs #1422; Chief thinking narrates that the workflow engine delivered the Inspect reply as a message.

    Acceptance add:

    • Node completion advances the graph / Workflow progress only — no inbox/「收到消息」leak into Chief or other persistent Bots.
    • Regression test: node replies do not create messages in the persistent Bot conversation.
  2. Birfy commented on Oct 27, 2026

    @Birfy
    CollaboratorAuthor

    Additional (owner 2026-10-27)

    Flowchart running node should show a clear animation that a Bot is actively running on that step (not only a static「运行中」badge).

    Owner wants to see at a glance which node Bot is live (e.g. pulse/spinner on Rework while Inspect=完成, Verify/Review=排队中).

    Acceptance add:

    • Active/running node has a visible motion cue (CSS animation / spinner) tied to live run state.
    • Idle / completed / queued nodes do not animate.
  3. Birfy commented on Oct 27, 2026

    @Birfy
    CollaboratorAuthor

    Additional (owner 2026-10-27)

    Polish the「把 Bot 拖到图上」roster: current three identical flat gray「Chief」chips look unfinished. Match chat+canvas style — clearer drag affordance, identity (avatar/initial), spacing/hover. Keep drag-to-graph.

  4. added a commit that references this issue on Oct 27, 2026
    2ede9d8
  5. Birfy commented on Oct 27, 2026

    @Birfy
    CollaboratorAuthor

    PR #1461 tip 2ede9d832bbff6cc20e7be3c08d9debd0dd38ea5 includes palette polish (gripped chips, avatars, duplicate-name hints, drag ghost).

  6. added 2 commits that reference this issue on Oct 27, 2026
    952d635
    510ccfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions