Repository navigation
fix(workflow): stage shows 「2 running」but 运行记录 lists only one; flowchart still tangled #1463
Description
Problem
Owner screenshots 2026-10-27 Asia/Shanghai on Workflow 「FlyBot PR → 合入」while a live run for PR #1422 is in Enqueue:
-
Running count mismatch — Stage header chip shows
2 running · queue 0, but the Workflow sidebar 运行记录 tab shows only one row tagged「运行中」for that same PR. Counts and list must agree: every live run that incrementsactiveCountmust appear in 运行记录 (and the chip must not double-count). -
Flowchart still messy — Stage「流程图」still shows tangled / fan-out connector paths to the right of Rework→Verify, a dashed「并行分支 · 全部通过后」box overlapping Verify, and a floating「Verify / 验证 / Instructions」card sitting on the wire plane. Owner:「这个流程图还是乱的！！！！」.
Context
- Workflow stage: fix broken flowchart edges; hide message composer #1459 / Fix Workflow stage UI and keep node replies off Chief chat #1461 (wire-plane, no composer, no Chief leak, run anim, palette) MERGED as
952d6358(tipd1b1054). Prod may still be on an older tip without that edge fix — agent must confirm whether residual layout bugs remain on currentmainafter Fix Workflow stage UI and keep node replies off Chief chat #1461, and fix any that do. - Chip copy comes from
plugins/workflow/client.js({count} running · queue {depth}whenactiveCount > 1orqueueDepth > 0);activeCountisrunningOf(lane).lengthinplugins/workflow/src/service.js. Hypothesis (non-binding): 运行记录 UI only renderscurrent+ history and drops sibling entries fromworkflow.runs/lane.active.
Acceptance
- When N live runs exist for a Workflow, header chip count equals N and 运行记录 lists exactly those N running rows (plus queued/history as today).
- No ghost / double-counted
activeCount(stalelane.activeentries withlive===truemust not inflate the chip). - On current
main, Settings + stage flowchart edges are clean between node anchors; parallel-branch frame and node instruction/inspector cards do not overlap the wire plane or other nodes. - Tests cover: two concurrent live runs → chip
2+ two running rows; one live run → no misleading2 runningchip; layout/edge regression for linear + parallel-when graph. -
docs/subsystems/workflow.mdnotes activeCount ≡ live running runs shown in 运行记录.
Owner
Birfy / bot-im
Do not merge to prod without owner yes.
Screenshots
Attached in follow-up comment / agent launch: flybot-wf-flowchart-still-messy.png, flybot-wf-running-count-mismatch.png.
Activity
Birfy commentedon Oct 27, 2026
Owner screenshots (local paths for implementer):
flybot-wf-flowchart-still-messy.png2 running · queue 0vs right 运行记录 only one「运行中」—flybot-wf-running-count-mismatch.pngImages attached to the cloud agent launch for #1463.
Birfy commentedon Oct 27, 2026
Owner follow-up (per-run controls)
Screenshot: stage header for
#1460shows one combined bar with chip2 running · queue 0and a single 暂停.Owner: 两个任务要分开来，分别可以暂停、停止等操作 — when there are multiple live concurrent runs, the stage must show each run as its own row/card with its own pause / stop (and resume) controls. Do not collapse N runs into one header + one shared Pause + a
N runningchip.Acceptance addendum:
N running · queue Dchip is optional summary only; it must not replace per-run controls.Birfy commentedon Oct 27, 2026
Owner follow-up (per-run progress)
Owner: 要能分别看到并发的任务的进度 — each concurrent live run must show its own progress (node / doneCount/nodeCount / strip), not one shared progress bar for all runs.
Acceptance addendum:
Fix workflow concurrent run UI and flowchart layout
Birfy commentedon Oct 27, 2026
Prod residual (tip
952d6358, 2026-10-27 Asia/Shanghai) — evidence only for #1467Flow drawer still clips the parallel-branch label / frame on the right on LIVE prod. Not a new issue; covered by #1467.