Skip to content

fix(workflow): room header Progress button does nothing visible #1491

Closed

Description

@Birfy

Problem

Written-by: FlyBotDebugger visual pass 5 (LIVE prod via cookie proxy)

On a Workflow room header (「FlyBot PR → 合入」), clicking Progress only focuses the button — it opens no popover, drawer, panel, or other visible UI. The same chrome already shows a segmented progress strip + Queued/Running badge, so the button currently looks interactive but is a no-op.

Expected

  • Clicking Progress should show progress / history (or run detail) for the active/last run, or
  • Hide / disable Progress when there is nothing useful to show

Context

Screenshots

04-progress-noop

01-header

Owner

Birfy / bot-im

Activity

  1. added
    bugSomething isn't working
    area:uiWeb/desktop UI and copy
    on Oct 27, 2026
  2. Birfy commented on Oct 28, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    Closing as already satisfied on main — the Progress button opens the ring drawer on the Runs tab. The build behind the report predates that wiring.

    What I checked (2026-10-28 ~04:35Z, main)

    • plugins/workflow/client.js:380 — the Progress button runs focus(); onOpenDrawer(); onTab('runs').
    • What those land on: onOpenDrawer: () => setDrawer(true) and onTab: (key) => { setTab(key); setDrawer(true) }. DrawerBody renders Runs for that tab (:446), and Runs lists the run-history rows, or says "No runs yet." when there are none — so the click cannot leave a dead button on main.
    • Ran the plugin suite: node --test plugins/workflow/test/client.test.js → 30/30 pass at main.
    • Extra throwaway check in the same test double, clicking Progress on a live run: aside.wf-drawer appears with the Runs tab selected — and it does so both at main and at fix(workflow,settings): UI polish passes 4-6 - composer, locale, header, Progress, Notifications, failed runs #1494's base commit 1b6f588c.

    About the merged PR

    #1494 carries Fixes #1491, but its Progress hunk is order-only: before focus(); onTab('runs'); onOpenDrawer?.(), after focus(); onOpenDrawer?.(); onTab('runs'). onOpenDrawer and onTab already set the drawer open at #1494's base, so the changelog line "now ensures the drawer opens" overstates the change — the behavior the issue asks for was already there.

    Why the visual pass saw a no-op

    The LIVE prod build behind the pass was v0.2.11 (published 2026-10-27T03:03Z), and that tag has no plugins/workflow/ at all — the stage chrome it showed is several releases older than main. The next release carries the drawer wiring; there is nothing left to implement for this report.

    If a build containing plugins/workflow/client.js from main still shows a Progress click with no drawer, reopen with that build's version and the plugin file's blob sha — that would be a new defect, not this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:uiWeb/desktop UI and copybugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions