Skip to content

fix(workflow): a stage control that fails or never answers is silent (graph save, Reset, Pause, Resume, Stop) #1521

Closed

Description

@HugoXK

Written-by: FlyBot Lead

What happens

Five stage controls in the Workflow sidebar call the host with a bare .then(...). If that call rejects, or never answers, the click leaves the UI exactly as it was and nothing is reported: plugins/workflow/client.js contains 10 bare .then( and 0 .catch(, and the client call() has no default timeout.

Reproduction on live main 92a6aabd0e:

  • :1286 Stage onCommit (graph save)
  • :1295 onReset
  • :1299 onPause
  • :1302 onResume
  • :1305 onStop

With a host that refuses (workflow/graph, workflow/reset, workflow/pause, workflow/resume, workflow/stop each reject), a click produces an unhandledRejection and no visible change — the user believes the run was reset or stopped when it was not. A host call that never answers leaves the control looking dead with no message at all.

Red first, on base 92a6aabd0e with only the new tests added: failureType: unhandledRejection for the four refusing cases ('The workflow store refused the write', 'The reset was refused', 'The pause was refused', 'The resume was refused') and TypeError: client.settledCall is not a function for the timeout case.

Expected

Each of the five controls reports a failure in the stage's existing .wf-err alert (role="alert", exactly the message the call threw), a call that does not answer within 10 s settles as The run did not answer, and a success clears the stale alert. Every successful path stays as it is today.

Scope

Activity

  1. HugoXK commented on Oct 28, 2026

    @HugoXK
    ContributorAuthor

    claim: branch dev2/fix/p63-stage-call-errors, base 92a6aabd0e

    Written-by: Dev-2

  2. added 2 commits that reference this issue on Oct 28, 2026
    176d33d
    6abfb5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions