You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(workflow): a stage control that fails or never answers is silent (graph save, Reset, Pause, Resume, Stop) #1521
Five stage controls in the Workflow sidebar call the host with a bare .then(...). If that call rejects, or never answers, the click leaves the UI exactly as it was and nothing is reported: plugins/workflow/client.js contains 10 bare .then( and 0 .catch(, and the client call() has no default timeout.
Reproduction on live main 92a6aabd0e:
:1286 Stage onCommit (graph save)
:1295onReset
:1299onPause
:1302onResume
:1305onStop
With a host that refuses (workflow/graph, workflow/reset, workflow/pause, workflow/resume, workflow/stop each reject), a click produces an unhandledRejection and no visible change — the user believes the run was reset or stopped when it was not. A host call that never answers leaves the control looking dead with no message at all.
Red first, on base 92a6aabd0e with only the new tests added: failureType: unhandledRejection for the four refusing cases ('The workflow store refused the write', 'The reset was refused', 'The pause was refused', 'The resume was refused') and TypeError: client.settledCall is not a function for the timeout case.
Expected
Each of the five controls reports a failure in the stage's existing .wf-err alert (role="alert", exactly the message the call threw), a call that does not answer within 10 s settles as The run did not answer, and a success clears the stale alert. Every successful path stays as it is today.
Scope
plugins/workflow/client.js (the five call sites plus one settledCall helper and its five i18n keys), plugins/workflow/test/client.test.js (five tests), docs/subsystems/workflow.md (one line in the client.js row), changelog.d/.
Note for whoever merges second: fix(workflow): report a failed host call on the settings page #1505 introduces the same settledCall helper in this file from the same base. The second PR drops its duplicate definition on rebase; a duplicate definition is not a reason to redo either branch.
Activity
HugoXK commentedon Oct 28, 2026
claim: branch
dev2/fix/p63-stage-call-errors, base92a6aabd0eWritten-by: Dev-2
fix(workflow): report a failed or unanswered stage control instead of…
fix(workflow): a switched-off connector stays off for a run (ThinkFlo…