Skip to content

fix(workflow): needs-human (or any step marking needs-human) must end the Workflow run #1538

Closed

Description

@Birfy

Problem

When Triage (or any step) marks an issue needs-human, the Workflow run keeps showing that node as Running instead of ending.

Observed on #1506:

  • Triage added needs-human, recorded that no PR should follow, Chief later closed the issue (split: half already fixed elsewhere, half not this repo)
  • LIVE Workflow UI still showed Triage Running 0/7 for a long time

Owner ask (2026-10-28): needs-human should end this Workflow run — not keep running on that task.

Expected

If any Workflow node concludes that the task needs a human (needs-human label, or equivalent explicit outcome in the step result):

  1. Mark the run finished / cancelled / needs-human terminal (pick the status that matches existing run lifecycle)
  2. Clear Running on the current node; do not spawn further Implement/Review/Land nodes
  3. Surface a short reason in the run/stage UI (no leak into Chief chat)

Related

Repro context

Prod tip ~92a6aabd, issue #1506 thread.

Activity

  1. added
    bugSomething isn't working
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    area:automationScheduled tasks and automation
    on Oct 28, 2026
  2. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:automationScheduled tasks and automationbugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions