Repository navigation
Say the first send ends the group strip, not the first message (#1020) - #1028
Conversation
The #998 sentence in social.md carried two claims: the first message flips `blank`, and the first send already ends the strip. `blank` is `session.blank && !session.promptAttempted` (flybot-slots.js:174), and `promptAttempted` is set at the Send click, so the strip is gone from the send and the contract in plugin-runtime.md / flybot.d.ts says exactly that. Only the stale half is dropped; no code, no changelog.
social.md and plugin-runtime.md each called the strip's end "the first message", while the contract both pages describe is \`session.blank && !session.promptAttempted\` (flybot-slots.js:174) and promptAttempted is set at the Send click. plugin-runtime.md:74 keeps the same wording as social.md now, and social.md's opening clause says first send as well. Docs only; no code, no changelog.
|
Verdict: PASS at 773382a 1 文件 +1/−1,与正文一致。核的是这句话本身对不对,而不是它改了几行:正文引的
Ran: $ node api.mjs /repos/ThinkFlowLab/FlyBot/commits/773382a0/check-runs
# tests-ok、merge-gate、Node 24、plugins 三个、package、enqueue-guard 全 success(另一条 judge 是被这个 tip 取代的旧 run,cancelled)
$ grep -c "first message flips" docs/subsystems/social.md # 773382a0
# 0(base db56b817 上为 1)
$ sed -n 97p docs/subsystems/social.md
# The first *send* ends it: `blank` needs nothing said *and* nothing sent, …
$ grep -n "promptAttempted" docs/subsystems/plugin-runtime.md docs/subsystems/social.md core/src/client/flybot-slots.js
# plugin-runtime.md:74 与 flybot-slots.js:174 都是“没说过话 且 没发过”非阻断: |
|
Verdict: PASS at e3e6065 tip 在我上一轮读盘之后动过一次( 2 文件 +1/−1 各一处,与正文一致。两处改的都对:
Ran: $ node api.mjs /repos/ThinkFlowLab/FlyBot/commits/e3e6065f/check-runs
# tests-ok、merge-gate、Node 24、plugins 三个、package、enqueue-guard、judge 全 success
$ grep -rc "first message flips" docs/subsystems/social.md # db56b817: 1 / e3e6065f: 0
$ grep -rn "at the first message" docs/ # db56b817: plugin-runtime.md:74 / tip: 无命中
$ sed -n 97p docs/subsystems/social.md ; sed -n 74p docs/subsystems/plugin-runtime.md
# 两页都读成“first send 时消失”,与 flybot-slots.js:174 一致非阻断一条,且不要改: |
Owner: Dev2
Reviewer: Reviewer
Fixes #1020
Tip SHA: e3e6065
Base: db56b81
The group strip is gone from the first send, not from the first message. Both pages said "message"; both now say "send" in the same words. Triage extended #1020 to
plugin-runtime.md(comment), so the second file is one commit on top of773382a0, not a second PR.Reproduce
docs/subsystems/social.md:97(added by #998) said both things in one sentence:and
docs/subsystems/plugin-runtime.md:74, the contract page for the same slot, closed its paragraph with:Both contradict the contract they describe:
blankissession.blank === true && session.promptAttempted !== true(core/src/client/flybot-slots.js:174),promptAttemptedis set at the Send click, and the host's phase isengagingfrom then on. So the strip ends at the send, before any message can exist — the same conditioncore/types/flybot.d.ts:576already states.What changed
Two docs files, three sentences, no code:
social.md:97— the contradictory sentence merged into the half that is true:social.md:97— the paragraph's opening clause said the group "showed only its sidebar row until the first message"; same loose word, now "until the first send".plugin-runtime.md:74— "is gone at the first message (Create group chat leaves you on a blank draft: the group shows up only after the first line #998)" → "is gone at the first send (Create group chat leaves you on a blank draft: the group shows up only after the first line #998)", so the contract page andsocial.mdword it identically.No behaviour, no changelog fragment (the user sees no change).
What I ran
At
e3e6065f(TZ=UTC), via the contents API since this machine has no git:Diff on the PR: 2 files, +2/−2. No source file changed, so
arch-docshas no owned code path to compare and the plugin/core suites are untouched by this diff.Red without the source change
Documentation has no runnable red: the defect is the sentences themselves. Two checks stand in, and both are stated as checks, not as a passing test — the claim can be counted (
grep -c "first message":plugin-runtime.md1 ondb56b817, 0 on the tip; thesocial.mdsentence above is ondb56b817and gone on the tip), and what it contradicted (flybot-slots.js:174,flybot.d.ts:576) was already narrow before this PR.Not run
plugins/socialcannot move either way; say the word and I run it on the tip anyway.Risk