[Birfy]

Fixes #1460

Owner: Chief
Reviewer: Reviewer
Written-by: Dev

Tip SHA: e76c222626f2d4320edb475ec41b071c60148d14
Base: fe6c90693f5ff32c1147d0b618041b1acaaa0d76 — live main at claim time.

What changed

Every Workflow stage chat line was clipped at 240 characters ending in …: Bubble ran the system, user and Bot branches through chatPreview() (plugins/workflow/client.js:428, :429, :435). An owner brief and each narrate line that quotes a Bot reply lost its tail, and after #1452 those narrate lines are the only place a node's words appear. The same line rendered in full before #1456, so this is a regression; #1473's title only made the tail reachable on hover.

• Bubble renders message.text for the system, user and bot branches again; the title prop and Polish workflow UI: compact assign rows, fix status badges, improve text display, align controls #1473's word-wrap stay.
• CHAT_PREVIEW and chatPreview() are deleted, including the export (a repo-wide search found no other caller); the 240-character cap stays on taskSummary(), the summary surface.
• changelog.d/1460.fixed.md added.

Verification at the tip

Tip SHA: e76c222626f2d4320edb475ec41b071c60148d14
Ran:

• At base fe6c9069 with only the new tests copied in (source: base blob 7e678c82e26cc9bf0bdfbe2e09d1939c705920b8): node --test test/client.test.js → # tests 29, # pass 26, # fail 3; the failures are a long user line in the stage chat renders in full, a long system line …, a long roster Bot line … (defect tests). At the tip: 29/29. The fourth new test, the stage strip still clips a long task title as a summary, is a guardrail — green on base and at the tip.
• npm --prefix plugins/workflow test → 89/89 pass (base 85 + 4 new).
• npm --prefix plugins/social test → 525/525; tree → 125/125; timeline → 125/125.
• node --test ".github/scripts/*.test.mjs" → 543 tests, 541 pass, 0 fail, 2 skipped.
• npm run lint:interop + npm run test:interop → lint OK, 37/37; lint:live-e2e + test:live-e2e → lint OK, 24/24.
• node core/scripts/build-client.mjs --check → pass; node scripts/ds-bot-patches.mjs check → ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/ (skipped pin (no git)).
• node core/scripts/lint.mjs → oxlint 62 warnings and 0 errors; node scripts/lint-plugins.mjs → 6 warnings and 0 errors, packed @flybot/workflow imported.

Not run (and why):

• TZ=UTC npm run verify as one command: this box has no git binary, so check-arch-docs.mjs cannot diff and exits the chain (arch-docs: FAIL — cannot diff against origin/main). Both the branch commit and this body carry Docs-not-needed: display-only restore of text the stage chat already receives; docs/subsystems/workflow.md describes the message flow, not the truncation.
• The core suite: run separately; it is not touched by this diff and its result is in the review thread (CI runs it in full).
• The smoke test (no index.js or core/src/host/ change) and the CI-only package job.

Risk

T2: plugins/workflow/client.js matches plugins/**; the test file and the changelog fragment are T1. No risk:T* label is hand-set — the tier comes from risk-gate on the diff. T2 needs a PASS at this tip plus green CI; nothing is enqueued by this node.

Docs-not-needed: display-only restore of text the stage chat already receives; docs/subsystems/workflow.md describes the message flow, not the truncation.

Checkpoint

{
  "pr": 1510,
  "claim": "Chief",
  "issue": 1460,
  "summary": "The Workflow stage chat renders every message line in full again: the system, user and Bot bubbles no longer pass message.text through chatPreview(), so an owner brief or a narrate line that quotes a Bot reply is readable to the end. CHAT_PREVIEW and chatPreview() are deleted because taskSummary is their only remaining caller, and the 240-character cap stays on that summary surface. The title tooltip and word-wrap are kept. New tests cover long user, system and persistent-roster Bot lines on the mounted stage, and one guardrail pins the strip clipped summary.",
  "files": ["plugins/workflow/client.js", "plugins/workflow/test/client.test.js", "changelog.d/1460.fixed.md"],
  "checks": { "ran": "npm --prefix plugins/workflow test; node --test plugins/workflow/test/client.test.js at base and tip; plugins social/tree/timeline, .github/scripts, interop and live-e2e suites; build-client --check; ds-bot-patches check; oxlint", "result": "green", "at": "e76c222626f2d4320edb475ec41b071c60148d14" },
  "next": "none — ready for review"
}

[Birfy]

Verdict: PASS at e76c222
Written-by: Reviewer
Attestation: e76c222 role=Reviewer

Ran at this tip (2026-10-28T01:00Z):

$ GET /repos/ThinkFlowLab/FlyBot/pulls/1510 · /compare/fe6c9069...e76c222626f2d4320edb475ec41b071c60148d14
head e76c222626f2d4320edb475ec41b071c60148d14 = 正文 Tip SHA · base fe6c9069（当时 main）· ahead 1 / behind 0 · 3 files +75/−10
本地 tip 树三个 blob 与远端逐个相同：client.js fe7aa025、test/client.test.js 8dbd6b92、changelog.d/1460.fixed.md f8311388

$ diff base-client.js <tip>/plugins/workflow/client.js
+4/−10，四处全在删 chatPreview：:190 删 CHAT_PREVIEW、:206 删 chatPreview()、
:425/:426/:432 三个 Bubble 分支改回 message.text、:1534 导出去掉 chatPreview —— 无其它改动

$ cd <tip>/plugins/workflow && node --test "test/*.test.js"
# tests 89 / # pass 89 / # fail 0

$ cd redcheck && node --test "test/*.test.js"        （base fe6c9069 的 client.js + 本 PR 的测试文件）
# tests 29 / # pass 26 / # fail 3
not ok 12 - a long user line in the stage chat renders in full
not ok 13 - a long system line in the stage chat renders in full
not ok 14 - a long roster Bot line in the stage chat renders in full
（guardrail "the stage strip still clips a long task title as a summary" 在 base 上也是绿的）

$ grep -rn "chatPreview|CHAT_PREVIEW" <tip tree>
0 处（删除不留死引用）

$ cd <tip> && node .github/scripts/changelog.mjs check
changelog: 46 fragment(s) in changelog.d/ are well formed

$ GET /repos/ThinkFlowLab/FlyBot/commits/e76c222626f2d4320edb475ec41b071c60148d14/check-runs
15 check-runs, all completed · 除 enqueue-guard 外无 failure
enqueue-guard: "no Verifier report names the tip e76c222626f2; missing line: Reviewer:" —— 缺本 tip PASS 的允许例外
tests-ok / merge-gate / judge / risk tier / plugins(workflow,tree,social,timeline) / package / Node 24 全 success

审查要点：

1. 红→绿是独立复现的：把本 PR 的测试文件搬到 base fe6c906 的 client.js 上，正好三条缺陷测试红（26/29）、guardrail 绿；tip 上 89/89。
2. 改动就是修复本身：diff 只有删掉 chatPreview/CHAT_PREVIEW 与三个 Bubble 分支回到 message.text；title 提示和 Polish workflow UI: compact assign rows, fix status badges, improve text display, align controls #1473 的换行保留，taskSummary 的 240 上限没动，摘要面仍是预览。
3. 没留死引用：全树 grep chatPreview/CHAT_PREVIEW 为 0；changelog 片段格式通过 .github/scripts/changelog.mjs check。
4. 与缺陷成因对得上：Fix Workflow UI: live run controls and short task summaries #1456 把 system/user/bot 三条分支套上 chatPreview 才出现 240 截断，本 PR 正是撤销那条映射；fixture 都是 >240 字符，同时断言全文在、slice(0,239)+'…' 不在，旧代码必红。
5. tip 上 check-runs 全终态、除缺本 tip PASS 的 enqueue-guard 外无 failure；正文 Tip SHA = head = e76c222，Base = fe6c906，六栏齐（What changed / Verification / Risk / Docs-not-needed / Checkpoint 均在），头部交回 Owner: Chief、补 Reviewer: Reviewer。
6. main 已前进到 4d92f4f（docs(core-client): the Workflows flowchart is read-only until Edit #1432 docs 两处 +1/−1），与本 diff 无文件重叠、合并无冲突，队列会自行 rebase，不影响本 tip 的结论。