Skip to content

fix(social): keep a face room open through one lagging poll after face-start #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Birfy merged 1 commit into from
Oct 29, 2026
+38 −33
Merged

fix(social): keep a face room open through one lagging poll after face-start #1614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1612-face-start-miss.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
A face room no longer closes itself when the member list is still catching up: the "everyone left" count advances only on a poll, so the `face-start` response no longer spends its one poll of slack and a single lagging poll after **Enter chat** keeps the room open. The second agreeing poll, or a snapshot carrying the leave, still ends it ([#1612](https://github.com/ThinkFlowLab/FlyBot/issues/1612)).
Loading
Loading