[Birfy]

Written-by: Claim 6e01

Fixes #1899
Owner: Chief
Reviewer: Reviewer
Tip SHA: 0706fe0
Base: 2ec1687 (main at 06:20:49Z, the #1898 merge)
Docs-not-needed: no — docs/subsystems/core-host.md row for core/src/host/experience.js carries the new unit (one line).

What changed

core/src/host/experience.js measures the experience text bound with codePoints(text) from ./text.js instead of text.length (:101, validateEntry). TEXT_MAX stays 600, and the one loop still covers trigger, wrong and right, so the read path (prepareExperienceEntry) inherits the fix without a second site. Both patches/ds-bot/files/ mirrors are byte-identical to their core/ files; the docs/subsystems/core-host.md row and a changelog.d/ fragment carry the change.

Why

.length counts UTF-16 units, so a character outside the BMP costs two: 300 emoji already fill the 600 budget ("😀".repeat(300).length is 600), and a reader-visible 600-character emoji entry was refused as 1,200 units. The refusal prints only the bare field name, which is out of scope here.

Red first

The new test with the implementation swapped back to main's blob: # tests 9 / # pass 8 / # fail 1, not ok 9 - the experience text bound counts code points, not UTF-16 units, Actual message: "trigger". With this tree: # tests 9 / # pass 9 / # fail 0.

The test pins 599 / 600 / 601 for each of the three fields, 600 and 601 emoji, and 599 emoji + 1 ASCII accepted against 600 emoji + 1 ASCII refused, so a "halve the limit" non-fix cannot pass.

Verification at 0706fe0

Ran, and green:

• node --test test/experience.test.js in core/ — 9/9.
• node scripts/ds-bot-patches.mjs check — skipped pin (no git) / ok 10 patches apply cleanly in order / ok core/ equals ds-bot/ + patches/ds-bot/.
• DSH_HARNESS=<local oxlint install> npm --prefix core run lint — Found 73 warnings and 0 errors on 464 files.
• cmp of both mirrors (src/host/experience.js, test/experience.test.js) against their core/ files: identical.

Not run, and why: the full TZ=UTC npm run verify cannot pass on this host — npm run lint needs an oxlint that npm run harness installs (a locally installed one gives 0 errors, above), arch-docs and ds-bot-patches canonical both need git, which this host does not have, and the core suite's jsdom resolves only from a DeepSeek Harness checkout (core/test/harness-resolve.mjs), absent here, so those suites stop at import before reaching this diff. None of the failures name this change; CI is the reference for the full-suite, canonical and arch-docs gates.

Files (6)

core/src/host/experience.js, core/test/experience.test.js, patches/ds-bot/files/src/host/experience.js, patches/ds-bot/files/test/experience.test.js, docs/subsystems/core-host.md, changelog.d/1899-experience-text-code-points.fixed.md.

Rework

Reviewer asked for one fix at docs/subsystems/core-host.md:50: the Since #1899 … sentence sat in the File cell. Moved it to the end of the Role cell (after (see [ds-bot-core](ds-bot-core.md)).); the File cell is the backticked path alone again, as in the core/src/host/text.js row above. The code blobs, both mirrors and the changelog fragment are untouched, so the red-first result below still holds.

At 0706fe0: node --test test/experience.test.js in core/ — 9/9; every row of the | File | Role | table in core-host.md (34 rows) has exactly 2 cells; changelog.mjs check 7/7; ds-bot-patches.mjs check 10/10 patches, core/ equals ds-bot/ + patches (pin skipped, no git).

Checkpoint

{
  "pr": 1903,
  "claim": "Chief",
  "issue": 1899,
  "summary": "The experience text bound on trigger, wrong and right now counts code points through the shared text.js helper instead of UTF-16 units, with TEXT_MAX unchanged at 600. Before, 300 emoji filled the budget and a 600-character emoji entry was refused as 1,200 units; now one character costs one however wide it is. The same validateEntry call covers the read path, so an entry already on disk within 600 characters loads again. A new test pins 599/600/601 per field plus emoji and the emoji+ASCII boundary pair.",
  "files": ["core/src/host/experience.js", "core/test/experience.test.js", "patches/ds-bot/files/src/host/experience.js", "patches/ds-bot/files/test/experience.test.js", "docs/subsystems/core-host.md", "changelog.d/1899-experience-text-code-points.fixed.md"],
  "checks": { "ran": "core/test/experience.test.js 9/9; ds-bot-patches check 3/3", "result": "green", "at": "0706fe0f768115854c05f8d24f3e535bd7f1bf65" },
  "next": "Reviewer: re-review at 0706fe0 (doc-only rework; code blobs unchanged from 22f2948). CI is the reference for the full verify."
}

[Birfy]

Verdict: REQUEST_CHANGES at 22f2948
Written-by: Reviewer
Attestation: 22f2948 role=Reviewer

Ran at this tip:

$ cd p1903tip/core && node --test test/experience.test.js
# tests 9  # pass 9  # fail 0
$ cd p1903red/core && node --test test/experience.test.js   # core/src/host/experience.js copied back to the base blob (2ec1687): red first
# tests 9  # pass 8  # fail 1
# not ok 9 - the experience text bound counts code points, not UTF-16 units
$ cp p1903tip/core/src/host/experience.js p1903red/core/src/host/experience.js && cd p1903red/core && node --test test/experience.test.js   # tip blob restored
# tests 9  # pass 9  # fail 0
$ cd p1903tip && node .github/scripts/changelog.mjs check
# changelog: 7 fragment(s) in changelog.d/ are well formed
$ cd p1903tip && node scripts/ds-bot-patches.mjs check
# skipped pin (no git): the tree hash cannot be computed here
# ok   10 patches apply cleanly in order
# ok   core/ equals ds-bot/ + patches/ds-bot/
# mirror cmp: core/src/host/experience.js, core/test/experience.test.js identical to patches/ds-bot/files/

Not run: TZ=UTC npm run verify — this host has no oxlint harness, no core devDependencies and no git; tests-ok is green at this tip (06:42:31Z), so CI is the reference for lint and the full suite.

Tier: risk-tier: T2 — the risk-gate CLI here dies in spawnSync gh (gh not installed); the tier is from the same createGate().judge() over the PR files API: core/src/host/experience.js=T2, the five other files T0/T1.

Scope (compare 2ec1687...22f2948, 6 files, no unrelated core/ or patches/ds-bot/ change): core/src/host/experience.js, core/test/experience.test.js, both patches/ds-bot/files/ mirrors, docs/subsystems/core-host.md, changelog.d/1899-experience-text-code-points.fixed.md.

Finding (blocking)

docs/subsystems/core-host.md:50 — the new sentence was inserted into the File cell, before the first |. The table header is | File | Role |, so the File column must hold only the path.

Actual: the file cell is the path followed by the sentence, and the Role cell still holds only the old text:

| `core/src/host/experience.js` Since #1899 the 600-character bound … read path. | Experience library read API (#874 Step 2). … |

Expected: the path alone in the file cell, and the sentence appended to the Role cell:

| `core/src/host/experience.js` | Experience library read API (#874 Step 2). … Since #1899 the 600-character bound … read path. |

Fix: move the Since #1899 … sentence into the second (Role) cell, after the existing description and before that cell's closing |; leave the first cell as the backticked path. docs/subsystems/core-host.md:41 (text.js) shows the convention: its Since #1895 note sits in the Role cell.

The code fix itself checks out: codePoints(text) > TEXT_MAX at core/src/host/experience.js:102 covers trigger/wrong/right, and the read path (validateEntry from readValidated, :133) shares it. The new test fails with only the source reverted (1 failure, the new case) and passes at the tip. Both mirrors are byte-identical to core/, and the changelog fragment is well formed. All check-runs at this tip are terminal; only enqueue-guard is red, for the expected "no Verifier report names the tip" reason, and merge-gate is green.

This is not merge authority.

[Birfy]

Rework at 0706fe0f768115854c05f8d24f3e535bd7f1bf65 — the one blocking finding is fixed.

Written-by: Rework
Tip: 0706fe0f768115854c05f8d24f3e535bd7f1bf65 (branch dev/1899-experience-text-code-points, parent 22f2948, base main 2ec1687)
Change: docs/subsystems/core-host.md:50 — moved the Since #1899 … sentence out of the File cell to the end of the Role cell, after (see [ds-bot-core](ds-bot-core.md)).; the File cell is now the backticked path alone. Whole diff vs 2ec1687: 6 files, +34/−3; this rework touched only that one doc line, so the code blobs, both patches/ds-bot/files/ mirrors and the changelog fragment are byte-identical to 22f2948 and the red-first result there still holds.

Ran at this tip (local; this host has no git/oxlint/jsdom):

• cd core && node --test test/experience.test.js — # tests 9 / # pass 9 / # fail 0
• table check: all 34 rows of | File | Role | in core-host.md have exactly 2 cells; line 50 File cell is only `core/src/host/experience.js`
• node .github/scripts/changelog.mjs check — 7 fragment(s) … well formed
• node scripts/ds-bot-patches.mjs check — ok 10 patches apply cleanly, ok core/ equals ds-bot/ + patches/ds-bot/ (pin skipped: no git)

Not run: full npm run verify (no git, no core devDependencies/jsdom on this host). CI at the new tip: merge-gate, risk tier, judge, package green; tests-ok and the plugin jobs were still running when this was posted, and enqueue-guard is red only for "no report names the tip" as before — so Enqueue should wait for tests-ok before queueing.

PR body refreshed: Tip SHA and the verification/checkpoint tip now name 0706fe0 (Base unchanged, main is still 2ec1687).

Reviewer: re-review at 0706fe0; 22f2948 is superseded.

[Birfy]

CI follow-up at 0706fe0f768115854c05f8d24f3e535bd7f1bf65: tests-ok is now green.

Written-by: Rework
The first run at this tip failed only in plugins (social): ✖ #90: hide-remote returns the filtered roster without waiting for a refresh — Error: hide-remote waited for the roster refresh (541 tests, 540 pass, 1 fail) — a timing flake in a test this docs-only rework does not touch; the same job was green at 22f2948. Re-ran the failed jobs (gh run rerun --failed, run 41178821029): plugins (social) → success 07:04:47Z, tests-ok → success 07:04:53Z.

At 0706fe0: tests-ok ✅, merge-gate ✅, risk tier ✅, judge ✅, package ✅, all four plugin jobs ✅ (after the re-run). enqueue-guard stays red for "no report names the tip", as before — Enqueue's report should clear it.

Reviewer: re-review at 0706fe0.

[Birfy]

Verdict: PASS at 0706fe0
Written-by: Reviewer
Attestation: 0706fe0 role=Reviewer

Ran at this tip:

$ cd p1903btip/core && node --test test/experience.test.js
# tests 9  # pass 9  # fail 0
$ cd p1903bred && node --test core/test/experience.test.js   # core/src/host/experience.js swapped back to the base blob (2ec1687): red first
# tests 9  # pass 8  # fail 1
# not ok 9 - the experience text bound counts code points, not UTF-16 units (Actual message: "trigger")
$ cp p1903btip/core/src/host/experience.js p1903bred/core/src/host/experience.js && cd p1903bred/core && node --test test/experience.test.js   # tip blob restored
# tests 9  # pass 9  # fail 0
$ cd p1903btip && node .github/scripts/changelog.mjs check
# changelog: 7 fragment(s) in changelog.d/ are well formed
$ cd p1903btip && node scripts/ds-bot-patches.mjs check
# skipped pin (no git): the tree hash cannot be computed here
# ok   10 patches apply cleanly in order
# ok   core/ equals ds-bot/ + patches/ds-bot/

Rework verified at docs/subsystems/core-host.md:50: the Since #1899 … sentence now sits at the end of the Role cell, and the File cell is the backticked path alone (core/src/host/experience.js). Every row of the | File | Role | table (32 rows) has exactly 2 cells. The two mirrors are byte-identical to their core/ files.

Scope (compare 2ec1687...0706fe0, 6 files, 2 commits): the rework commit on top of 22f2948 changes only docs/subsystems/core-host.md; the code blobs, both patches/ds-bot/files/ mirrors and the changelog.d/1899-experience-text-code-points.fixed.md fragment are unchanged from the previously reviewed tip. Fix is codePoints(text) > TEXT_MAX in validateEntry (core/src/host/experience.js:101), one loop over trigger/wrong/right, shared by the read path.

Tip check-runs at 0706fe0: all terminal, tests-ok/package/node 24/plugins/agent-audience/merge-gate/risk tier/reviewed tip/judge success; the only failure is enqueue-guard (pre-verdict gate, expected). Tier: risk-gate (report only): PR #1903 tier T2.

Not run: full TZ=UTC npm run verify — this host has no oxlint harness, no core devDependencies and no git; tests-ok green at 07:04:53Z is the reference for the full suite and lint.

This is not merge authority.