Skip to content

build(mac): add branded dmg layout#2013

Merged
yyhhyyyyyy merged 1 commit into
devfrom
build/macos-dmg-layout
Jul 24, 2026
Merged

build(mac): add branded dmg layout#2013
yyhhyyyyyy merged 1 commit into
devfrom
build/macos-dmg-layout

Conversation

@yyhhyyyyyy

@yyhhyyyyyy yyhhyyyyyy commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator
  • add branded 1x and Retina 2x DMG background assets
  • configure the DeepChat app and /Applications link positions
  • align the icon-and-label groups with the background cards
  • let electron-builder derive the Finder window size from the background image
  • classify both background assets as macOS packaging inputs
  • add regression coverage for the DMG layout, image dimensions, and package-impact rules

Summary by CodeRabbit

  • New Features

    • Improved macOS installer presentation with a custom background, refined icon sizing, and a clearer drag-to-Applications layout.
    • Added support for new AI models, modalities, capabilities, and provider offerings.
    • Updated available agent integrations to newer releases, including Factory Droid, Fast Agent, GitHub Copilot CLI, and Goose.
  • Bug Fixes

    • Improved packaging detection so changes to macOS installer artwork are correctly recognized during builds.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The PR configures macOS DMG presentation and packaging detection, updates ACP agent releases, and expands provider model metadata with new models, capabilities, limits, endpoints, dates, and pricing.

Changes

DMG packaging

Layer / File(s) Summary
DMG layout and packaging contract
electron-builder.yml, scripts/ci/classify-package-impact.mjs, test/main/scripts/*
Adds DMG backgrounds, icon sizing, positioned contents, PNG dimension checks, and macOS package-impact assertions while relaxing notarization matching to allow additional DMG fields.

ACP agent registry

Layer / File(s) Summary
Agent release metadata
resources/acp-registry/registry.json
Updates factory-droid, fast-agent, GitHub Copilot CLI, and goose versions, package references, archives, and checksums.

Provider model catalog

Layer / File(s) Summary
General provider model entries and pricing
resources/model-db/providers.json
Adds and updates Tencent, MiniMax, MiniCPM, Hermes, Gemma, Nemotron, Cosmos, and related model metadata.
Thinking Machines provider metadata
resources/model-db/providers.json
Switches provider endpoints to Anthropic-compatible URLs and updates Inkling model definitions and limits.
Gemini model catalog expansion
resources/model-db/providers.json
Adds or updates Gemini image, audio, video, embedding, computer-use, deep-research, Veo, robotics, and live-preview entries.
Additional model catalog updates
resources/model-db/providers.json
Adds InclusionAI models and adjusts existing model limits, dates, and pricing fields.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

Suggested reviewers: zhangmo8

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: a branded macOS DMG layout.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build/macos-dmg-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
resources/model-db/providers.json (1)

123760-123763: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Disambiguate the two Inkling entries' display names.

The base thinkingmachines/Inkling and the thinkingmachines/Inkling:peft:262144 variant both carry name/display_name = "Inkling", so they render as two indistinguishable options in the model picker. Consider differentiating the PEFT/262k-context variant.

♻️ Suggested change
           "id": "thinkingmachines/Inkling:peft:262144",
-          "name": "Inkling",
-          "display_name": "Inkling",
+          "name": "Inkling (PEFT 262K)",
+          "display_name": "Inkling (PEFT 262K)",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@resources/model-db/providers.json` around lines 123760 - 123763, Update the
display_name for the thinkingmachines/Inkling:peft:262144 model entry to
distinguish it from the base thinkingmachines/Inkling option, while preserving
its id and name fields.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/model-db/providers.json`:
- Around line 204665-204668: Update the limit.output value for the
veo-3.1-generate-preview provider entry from 1 to 8192, matching the sibling Veo
3.1 preview variants and preserving the existing context limit.

---

Nitpick comments:
In `@resources/model-db/providers.json`:
- Around line 123760-123763: Update the display_name for the
thinkingmachines/Inkling:peft:262144 model entry to distinguish it from the base
thinkingmachines/Inkling option, while preserving its id and name fields.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 28840977-f03b-49e2-984e-ba8e1e5d0078

📥 Commits

Reviewing files that changed from the base of the PR and between 15d232b and 0e47ead.

⛔ Files ignored due to path filters (2)
  • build/dmg-background.png is excluded by !**/*.png
  • build/dmg-background@2x.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • electron-builder.yml
  • resources/acp-registry/registry.json
  • resources/model-db/providers.json
  • scripts/ci/classify-package-impact.mjs
  • test/main/scripts/dmgLayout.test.ts
  • test/main/scripts/notarizeDmg.test.ts
  • test/main/scripts/packageContract.test.ts

Comment thread resources/model-db/providers.json
@yyhhyyyyyy
yyhhyyyyyy merged commit 61d3df1 into dev Jul 24, 2026
21 checks passed
@zhangmo8
zhangmo8 deleted the build/macos-dmg-layout branch July 24, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant