Move DependencyTracker specs from system to integration tier - #1286
Merged
Merged
Conversation
PR 1 of the system-test redesign (Stage 2 plan, Finding 4): these 6 specs already match spec/integration/'s own charter, not spec/system/'s -- real DependencyTracker/FileWrapper/etc. against a real Dir.mktmpdir temp directory, but no CLI subprocess, no gem deployment, and (per dependency_tracker_gcc_deps_spec.rb's own header) not even a real gcc invocation. Mechanical move: directory, helper module name/location, and each file's declared tier (describe string + header comment) change; no assertion, fixture, or collaborator wiring changes. Two stray comment cross-references elsewhere (a unit spec, delta_builds_spec.rb) updated to point at the new location. Coverage is identical before and after -- same real collaborators, same real temp-directory fixtures, same 48 examples, same 1-2 platform-gated pending cases (mirror image depending on host filesystem case-sensitivity). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 1 of 5 in the system-test redesign (Stage 2 plan, following the "System Test Duplication Assessment" report's Finding 4). These 6 specs already match
spec/integration/'s own charter, notspec/system/'s: realDependencyTracker/FileWrapper/etc. against a realDir.mktmpdirtemp directory, but no CLI subprocess, no gem deployment, and — perdependency_tracker_gcc_deps_spec.rb's own header comment — not even a realgccinvocation.Changes
spec/system/dependencies/*.rb(6 files) →spec/integration/dependencies/spec/support/system/dependency_tracker_system_helper.rb→spec/support/integration/dependency_tracker_integration_helper.rb, module renamedDependencyTrackerSystemHelper→DependencyTrackerIntegrationHelperrequire,include,describe '... (system)'string, and header-comment tier language updated to matchspec/units/dependencies/dependency_tracker_spec.rb,spec/system/delta_builds_spec.rb) updated to point at the new locationPurely mechanical — no assertion, fixture, or collaborator wiring changed. Coverage is identical before and after.
Verification
spec/integration/dependencies/: 48/48 examples pass, host (macOS) and themadsciencelab-pluginsDocker image (Linux) — with the expected 1-2 platform-gated pending cases (case-sensitivity scenarios, mirror image depending on host filesystem).rake specs:integration: 85/85 examples pass (37 pre-existing + 48 moved).dependency_tracker_spec.rb): 55/55 pass, unchanged behavior.grepconfirms no remaining reference to the oldspec/system/dependenciespath anywhere in the repo.This is PR 1 of 5; the plan calls for a go-ahead before starting PR 2 (Cluster E shared scaffold).
🤖 Generated with Claude Code