PR 5: Consolidate files:/paths: reporting, trim example-project redundancy - #1290
Merged
Merged
Conversation
files:*/paths:* task-reporting output was previously checked three times over as an incidental side effect of temp_sensor, cipher_quest, and wondrous_forest's own example-project coverage. Give it one dedicated home (files_paths_reporting_spec.rb, built against temp_sensor) instead, and trim each example-project file down to what's actually unique to it: temp_sensor 39->5 (keeps test:path[], its sole coverage anywhere; drops TemperatureCalculator/pattern[Temp] as redundant with wondrous_forest/ pinned_thread_count/delta_builds; drops relative-path and env-named mixin variants now covered as mechanisms by mixin_loading_spec.rb/ mixin_ordering_spec.rb), cipher_quest 14->5 (drops inline-YAML mixin duplicates of its own sigil-file release builds), wondrous_forest 7->2 (drops pattern[Sensor] as redundant, promotes test:SoilMoisture to the suite's sole single-module-test example). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final PR in the Stage 2 system-test redesign plan (see PRs #1284/#1287/#1288/#1289 for the prior four phases).
files:*/paths:*task-reporting output had no dedicated coverage anywhere — it was checked three times over, only as an incidental side effect ofexample_temp_sensor_spec.rb,example_cipher_quest_spec.rb, andexample_wondrous_forest_spec.rb's own project-specific assertions. Consolidating isn't just dedup here — it gives that output a real, non-redundant home for the first time.spec/system/files_paths_reporting_spec.rb— 9 examples (files:header/source/support/test/assembly,paths:include/source/support/test), built againsttemp_sensor(richest src/test/support layout of the three example projects).example_temp_sensor_spec.rb: 39 → 5 examples. Dropstest:TemperatureCalculator/test:pattern[Temp](redundant withwondrous_forest'stest:SoilMoistureandpinned_thread_count_spec.rb/delta_builds_spec.rb's own pattern-test coverage) and the relative-path/env-named mixin-loading variants (now covered as mechanisms bymixin_loading_spec.rb/mixin_ordering_spec.rb). Keeps the sole coverage oftest:path[]and--test-case=anywhere in the suite.example_cipher_quest_spec.rb: 14 → 5 examples. Drops the three inline-YAML mixin duplicates of its own sigil-file release builds — inline-YAML syntax is proven once elsewhere; the three sigil-file builds (ROT13, Caesar, full-featured) are functionally distinct feature-selection scenarios and are kept.example_wondrous_forest_spec.rb: 7 → 2 examples. Dropstest:pattern[Sensor](redundant withpinned_thread_count_spec.rb/delta_builds_spec.rb);test:SoilMoisturebecomes the suite's sole remaining single-module-test example.Coverage retention: every dropped assertion's behavior is named above as either kept once elsewhere in this same PR, or already covered by an untouched Cluster D file or the PR 4 mixin specs.
Test plan
bundle exec rspec spec/system/files_paths_reporting_spec.rb spec/system/example_temp_sensor_spec.rb spec/system/example_cipher_quest_spec.rb spec/system/example_wondrous_forest_spec.rb— 21 examples, 0 failures, hostmadsciencelab-plugins:1.1.0Docker imageThis is the last PR in the Stage 2 plan.
🤖 Generated with Claude Code