feat: modernize repo for Pi-hole v6 - #3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 024544ebee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 1. Clone the repo or copy `docker-compose.yml` and `.env`. | ||
| 2. Edit `.env` to set your secure password and timezone. |
There was a problem hiding this comment.
Include the environment template used by the quickstart
The documented .env file is absent from the commit (and the existing *.env ignore rule would prevent adding it normally), while docker-compose.yml obtains PIHOLE_PASSWORD from that file. A user following these steps therefore cannot edit the promised template, and starting the stack as written leaves the configured API password value undefined. Track a non-secret template such as .env.example and update these instructions, or document the required variables explicitly.
Useful? React with 👍 / 👎.
Resolves #2. Updates READMEs, adds docker-compose with FTLCONF, and adds missing files.