Skip to content

refactor: extract _save_config_safely helper in TTS window #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimInTech merged 1 commit into from
Sep 18, 2026
Merged

refactor: extract _save_config_safely helper in TTS window #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 14 additions & 24 deletions app/tts_window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ def _safe_unlink(path: Optional[str]) -> None:
pass


def _save_config_safely(config) -> None:
"""Persist the config; write errors are deliberately ignored."""
try:
config.save()
except Exception:
pass


def _make_tts_runtime_job_dir() -> Path:
return Path(tempfile.mkdtemp(prefix=f"blitztext-tts-{uuid4().hex}-", dir=TTS_RUNTIME_DIR))

Expand Down Expand Up @@ -559,10 +567,7 @@ def _ensure_openai_consent(self) -> bool:
if answer != QMessageBox.StandardButton.Yes:
return False
self._config.tts_openai_consent = True
try:
self._config.save()
except Exception:
pass
_save_config_safely(self._config)
return True

def _revert_provider_to_piper(self) -> None:
Expand All @@ -571,10 +576,7 @@ def _revert_provider_to_piper(self) -> None:
self._provider_combo.blockSignals(False)
if self._config.tts_provider != "piper":
self._config.tts_provider = "piper"
try:
self._config.save()
except Exception:
pass
_save_config_safely(self._config)

@pyqtSlot(int)
def _on_provider_changed(self, _idx: int) -> None:
Expand All @@ -586,10 +588,7 @@ def _on_provider_changed(self, _idx: int) -> None:
return
if self._config.tts_provider != provider:
self._config.tts_provider = provider
try:
self._config.save()
except Exception:
pass
_save_config_safely(self._config)
self._populate_voices()
self._refresh_status_hint()

Expand All @@ -600,27 +599,18 @@ def _on_voice_changed(self, _idx: int) -> None:
if provider == "openai":
if isinstance(voice, str) and voice and self._config.tts_openai_voice != voice:
self._config.tts_openai_voice = voice
try:
self._config.save()
except Exception:
pass
_save_config_safely(self._config)
else:
if isinstance(voice, str) and voice and self._config.tts_voice != voice:
self._config.tts_voice = voice
try:
self._config.save()
except Exception:
pass
_save_config_safely(self._config)
self._refresh_status_hint()

def _on_model_changed(self) -> None:
model = self._model_edit.text().strip() or OPENAI_TTS_MODEL_DEFAULT
if self._config.tts_openai_model != model:
self._config.tts_openai_model = model
try:
self._config.save()
except Exception:
pass
_save_config_safely(self._config)
self._refresh_status_hint()

@pyqtSlot(int)
Expand Down
Loading