refactor: deepen architecture + efficiency optimizations#24
Open
Timidan wants to merge 3 commits into
Open
Conversation
Applied 9 unambiguous fixes from a 10-zone CLAUDE.md audit (~150 total findings). Only items with zero behavior change, zero parallel-work conflict (PR #20 lifi-intents, #21 mezo, #22 cleanup), and clear dead-code or surface-confusion signal were applied; the rest are deferred to the PR description as a backlog. Net: 12 files, -65 lines net. Surface confusion (P1): - structStorageDecoding.ts:484 — collapse identical-branches ternary 'const elementSize = elementType === 'address' ? 1 : 1' → '= 1' - storageSlotCalculator.ts:86 — parseSlotInput dropped redundant hex branch (both branches called BigInt(trimmed)) - edbTraceConverter.ts:55 — same redundant-hex-branch in parseTraceValue Speculative API surface (P2): - SolidityViewer.tsx — removed unused props highlightLine, scrollToLine, theme (sole caller never passes any) - PackingVisualizer.tsx — removed unused rawHex prop + caller's pass - api/{lifi-composer,lifi-earn,edb-proxy}.ts — dropped 'HEAD' from ALLOWED_METHODS (no caller issues HEAD) Dead exports (P3): - scripts/bridge-security.mjs — sanitizeForLogging (zero callers) - scripts/bridge-config.mjs — TRACE_DETAIL_COMPACT_ARTIFACTS env constant (zero readers) - eslint.config.js — ignore globs for nonexistent dirs (current_bundle, test-results, test-*, **/test-*.js, test-app-*)
Consolidate duplicated/scattered logic behind single seams and add measured, behaviour-preserving efficiency wins. Deepening: - trace decoder: createPcResolvers factory + single traceIdFromFrame - storage: placeField/elementsPerSlot + walkStorageEntries primitives; resolveAbiKeyType/buildScalarDescriptor (fixes silent string-key probe) - contract resolution: delete deprecated multiSource/comprehensive shims; facetAdapter over the resolver seam - debug eval: traceRowScoring + snapshotCacheStore (one eviction policy) - sim persistence: simulationStore coordinator; deleteDecodedTrace fixes orphaned OPFS traces on delete - integrations: evmRead provider helper Efficiency: - diamond loupe facets()-first reuses selectors (drops per-facet RPC) - bounded mapping-slot keccak cache - SelectorDecoder batched + chunked OpenChain lookup with circuit breaker - recomputeHierarchy O(n^2) -> O(n); skip redundant recompute on OPFS load - lazy-load Navigation, split framer-motion to an async chunk
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 214f89bd15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const ALLOWED_METHODS = new Set(["GET", "POST", "OPTIONS"]); | ||
|
|
||
| // CORS allowlist — dev servers by default; extend via EDB_CORS_ALLOWED_ORIGINS (comma-separated). | ||
| const DEFAULT_ALLOWED_ORIGINS = new Set([ |
There was a problem hiding this comment.
When a client or health checker sends a HEAD request to /api/edb/*, this allowlist now rejects it with 405 before the proxy reaches the existing HEAD-specific path below (the CORS header still advertises HEAD, and the body handling explicitly skips bodies for HEAD). This makes HEAD probes fail even though the rest of the handler is still written to forward them safely.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates duplicated/scattered logic behind single seams and adds behaviour-preserving efficiency wins.
tscclean, production build green.Deepening
traceIdFromFrame(was duplicated across the decode files)Efficiency
facets()-first reuses selectors, dropping per-facet RPC callsrecomputeHierarchyO(n²)→O(n); skip a redundant recompute on history loadBehaviour
Behaviour-preserving except three intentional fixes: nested-struct storage layout, the string-keyed mapping probe, and orphaned OPFS traces on delete.