Repository navigation
attestation: hash report data before GetQuote - #295
Merged
Merged
Conversation
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
Security read: approve
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
Astra review: approve
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
Security read: approve
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
Astra review: approve
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
Astra review: approve
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
Security read: changes requested (details tracked internally)
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
Astra review: approve
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
Security read: approve
…ation-report-data # Conflicts: # CHANGELOG.md
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/attestationsends SHA-256 ofkey_binding(32 bytes) as GetQuote report data and returns it askey_binding_sha256next to the preimage.report_dataecho, and the REPORTDATA field of the returned TDX v4 quote; otherwise 503.nonceis limited to 1-64 URL-safe characters; the endpoint uses the public per-IP rate limit.docs/attestation.md.Tests: stub guest-agent socket with a structurally valid quote fixture; 64-byte bound, error status, REPORTDATA/echo mismatch, truncated quotes, digest recomputation, nonce and rate limit.
Linear: TC-963