Repository navigation
Conversation
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
APPROVE — TC-735
Contributor
Author
|
REQUEST_CHANGES: see TC-735 |
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
REQUEST_CHANGES — TC-735
Contributor
Author
|
APPROVE: see TC-735 |
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
APPROVE — TC-735
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fetch authorization closure edges, delegations, abilities and revocations in one tagged SQL query; rebuild the snapshot in Rust. Capability validation, revocation rules and schema stay unchanged. This main-based PR is required before TC-735's pre-persist write-path PR #301.
The metadata joins use a planner-visible 65-node (64 valid + overflow sentinel) lookup relation. The full closure and edge budget checks remain separate; 64 nodes load completely and 65/66 fail closed. Ability rows have a canonical typed
(resource, ability)order across databases. Allow/deny outcomes do not change; only the diagnostic reason when several caveats all reject may normalize from the former backend-dependent order. SDK/CLI do not assert that graph rejection text; existing node containment-vector codes test the separate containment helper.Evidence
Coordination
TC-1149/#298 owner reviewed the earlier diff; its principal/alias closure helpers must survive rebase. Request fresh Astra and Miller review of 082393b. No merge or deployment requested.