Repository navigation
test(TC-959): use pre-N0 template fixture in recovery tests - #318
Merged
Merged
Conversation
Future-digest and normal-build recovery cases ran against the repository's current compose. Since #309 that file is the reviewed N0 compose, which the workflow intentionally refuses to pair with any image other than the reviewed 1.20.6 digest. Run these cases against a frozen copy of the pre-N0 template (sha256 28302d67...) instead, and assert the N0 compose refuses a normal build image as it already refuses a future digest.
Same bytes (sha256 28302d67...) as the frozen copy, without adding a fixture file; matches the derivation used by #315.
Contributor
Author
|
APPROVE: see TC-959 (reviewed exact head 36265f9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
Docker Containerrun 39001586915 failsversion-guardinscripts/ci/test-deploy-recovery.py:test_future_digest_gets_preflight_and_general_quota_restoretest_normal_build_deployment_keeps_preflight_and_general_quotaCause: these cases used the repository's current
docker-compose.dstack-postgres.yaml. After #309 that file is the reviewed N0 compose (sha256ca110b0b…), and the workflow refuses it withReviewed N0 compose cannot substitute a different image(docker.yml, before any CVM mutation). That refusal is intended behaviour.Change (only
scripts/ci/test-deploy-recovery.py; no workflow, guard, hash, lock, orops/changes):PRE_N0_TEMPLATE=ops/rollback/pre-n0-compose.yamlwith the 1.20.6 digest pin reverted to:dstack. This reproduces the pre-Add a compose-only node log sidecar #309 template (sha25628302d67…, asserted when the module loads). It uses the same derivation as ci: promote a released main image with the reviewed N0 compose template #315.PRE_N0_TEMPLATE. After Add a compose-only node log sidecar #309,CURRENTandN0were identical, so the pre-N0 subtest oftest_recovery_current_pre_n0_and_reviewed_n0had been running N0 twice.test_forward_n0_lock_and_captured_rollback_are_not_substitutablenow also asserts that the N0 compose refuses a normal-build image.The 12c same-image command (1.20.6 /
4bdae4fc/e18578ff) against main's actual compose is still covered bytest_documented_recovery_and_both_rollback_commandsand by the N0 subtest oftest_recovery_current_pre_n0_and_reviewed_n0. Both pass.Local: test-docker-tags.py ok, test-quota-authority.py 20/20, test-deploy-recovery.py 17/17, test-check-deploy-ref.sh rc=0,
reconcile-quota.py --validate-onlyok.