Repository navigation
Conversation
Contributor
Author
|
APPROVE: see TC-1162 (reviewed exact head 2789efc) |
…thority-billing # Conflicts: # docs/releasing.md
Contributor
Author
|
APPROVE: see TC-1162 (reviewed exact head 004d9be) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs TC-1162 / TC-1164.
Changes
ops/quota-overrides.json:authority→billing; secrets floor 268721121 → 1073741824 (Sam set 1 GiB via /storage 2026-10-17T05:36:53Z; internal D1 is the source); applications floor stays 5368709120. Comments now describe billing-mode floors.scripts/ci/reconcile-quota.py:LIMITSsecrets → 1073741824; the node-override success message is built fromLIMITS, so it can't drift from them.scripts/ci/test-quota-authority.py: fixtureLIMITSupdated; new testtest_shipped_billing_config_reconciles_against_exact_floors.docs/releasing.md: billing is now described as the current authority, with the floors and the ordering/revert rule (reverting to node-override needs a reviewed PR).Test coverage
Tests that already covered the guards, using synthetic configs:
test_billing_mode_uses_absolute_limit_and_accepts_cold_node_cache(billing passes with no PUT),test_billing_absent_inactive_or_insufficient_fails_without_mutation(comp one byte below the floor),test_stale_local_override_rejects_billing_mode, andtest_active_comp_on_second_space_blocks_every_legacy_put(authority mismatch).What the new test adds: it runs full
main()against the checked-inops/quota-overrides.json, not a synthetic copy. With comps exactly at 5368709120 / 1073741824 and nodeoverride_bytes=null, it passes with zero PUT/DELETE. With the secrets comp at 1073741823 (one byte under the new floor), it failsbilling authority does not cover both reviewed quota floors. With the shipped values in a temp copy set tonode-overrideand an active comp, it failsauthority mismatch: flip to billingwith no PUT.Tests
python3 scripts/ci/test-quota-authority.py: 22 tests OKpython3 scripts/ci/test-deploy-recovery.py: 17 tests OKpython3 scripts/ci/reconcile-quota.py --validate-only: "Reviewed quota authority and targets validated."