Repository navigation
test(TC-887): base32 runs end at their own alphabet; name 3+ salt pieces as out of scope - #344
Merged
Merged
Conversation
…ces as out of scope Approval nits on #340: - Encoded runs are now taken per alphabet (all decoders together, and base32, hex and base64url each on their own), in block bodies and names and in mirror strings, so a base32-encoded secret followed by a character outside base32 (9, 1) is still decoded at every alignment. Self-test covers a block body and a mirror string, and fails with the previous single-alphabet runs. - README: the out-of-scope list names a secret split into 3 or more pieces across salts.
Contributor
Author
|
APPROVE: see TC-887 (head |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TC-887 harness: the two non-blocking nits from the #340 approval. No product code changes.
What changed (
tests/at_rest_harness.rs,scripts/at-rest-harness/README.md)9or1stayed inside a longer run that didn't decode as base32.How it's tested
selftest_base32_secret_before_other_characters:9and by1after the ciphertext of a block body;9and by1in an extra field of a DEK mirror.With the old union-only runs put back, it misses all 4 cases; with the fix, it passes.
cargo test -p tinycloud-node --test at_rest_harness: 11 passed, 4 ignored.cargo clippy … --test at_rest_harness -- -D warningsandcargo fmt --checkare clean.