Repository navigation
TC-1777 N5: gate encryption-named-keys-v1 in /info behind a config flag - #416
Merged
Merged
Conversation
added 5 commits
October 23, 2026 09:08
…y_invalid The 400 for a receiver public key that is malformed or a low-order point now begins with the stable code receiver_key_invalid on both decrypt routes. Status is unchanged. Details: TC-1777
Adds encryption_network.named_keys_v1 (default off). /info and /version advertise the feature only when it is on. Production now manages Config as Rocket state so the route can read it. Details: TC-1777
AdHoc::config::<Config>() already manages Config as Rocket state, so the extra .manage(tinycloud_config.clone()) aborts startup with "duplicated managed state". Reverts the line added in f06b916. Details: TC-1777
Document the flag in the example tinycloud.toml (commented, off). Details: TC-1777
samgbafa
marked this pull request as ready for review
October 23, 2026 10:46
Contributor
Author
|
APPROVE: see TC-1777 (reviewed exact head 7c99f96) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[global.encryption_network] named_keys_v1, defaultfalse. Env override:TINYCLOUD_ENCRYPTION_NETWORK__NAMED_KEYS_V1=true.encryption-named-keys-v1entry in theGET /infofeature list. It does not mount or unmount routes, and it does not change request handling.receiver_key_invalid:on both routes.Verification
RUSTFLAGS="-Dwarnings" cargo clippy --workspace --all-targets: exit 0.cargo fmt --all -- --check: exit 0.node scripts/gen-capabilities.mjs --check: up to date.cargo test -p tinycloud-core --lib: 758 passed, 0 failed.cargo test -p tinycloud-node --lib: 716 passed, 0 failed. Includesnamed_keys_feature_is_advertised_only_behind_its_gateand theencryption_network_named_keys_*config tests.tinycloudbinary on 127.0.0.1:/infofeatures omitencryption-named-keys-v1with the flag off, and include it with the env override or the TOML key set totrue.Not covered here
Commits
3350eabreceiver-key refusal error codef06b916config-gated/infoadvertisement9fd3d2echangelog note for the config key41ae565drop duplicateConfigmanage (AdHoc::configalready manages it)7c99f96config tests and example configDetails: TC-1777