Repository navigation
personal-node: pin published 1.22.0 and rehearse the 1.20.6 -> 1.22.0 upgrade - #434
Merged
Merged
Conversation
… upgrade compose.yaml and node.sh pin the 1.22.0 image index sha256:2f3c65d85aa94610456bf09cd54713bab5260097bb3d56858025bc6eadb5a4a0, taken from the docker.yml run for the v1.22.0 tag. The 1.20.6 image is kept only as the previous image of the upgrade rehearsal. ci.sh runs a fresh 1.22.0 install, then 1.20.6 -> 1.22.0 with backup, fresh restores, and rollback by restoring the pre-upgrade snapshot onto 1.20.6. check-version also asserts that the named-key and delegated SQL caveat features are not listed. The README records the database migrations the upgrade applies and that rollback is a restore. Details: TC-1282
node.sh check-bare-image-missing-key starts the 1.22.0 image as shipped (no mounted config, key or environment) and requires exit 1 plus the node's exact ` Missing secret` line, using the same matcher as check-missing-key. ci.sh runs it on the fresh 1.22.0 instance, after the version check. The README states what is and is not run bare. Details: TC-1282
The compose comment and the README launch section state what the mounted keyless config does and which image each CI check starts, without describing other images. Details: TC-1282
Contributor
Author
|
APPROVE: see TC-1282 (reviewed exact head 915e6a8) |
samgbafa
marked this pull request as ready for review
October 23, 2026 23:00
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
deploy/personal-node/compose.yamlandnode.sh: the ordinary profile pins the published 1.22.0 image indexsha256:2f3c65d85aa94610456bf09cd54713bab5260097bb3d56858025bc6eadb5a4a0. The digest is the manifest list pushed by thedocker.ymlrun for thev1.22.0tag (run 40031807112, jobbuild, "Digest" group; the same value appears in thepushing manifest for ghcr.io/tinycloudlabs/tinycloud-node:1.22.0@sha256:...lines). No image was pulled to obtain it.sha256:41667d3d...) is innode.shonly as the previous image of the upgrade rehearsal. The 1.20.5 image is removed.deploy/personal-node/ci.sh: a fresh 1.22.0 install; then 1.20.6 -> 1.22.0 with signed KV/SQL checks before and after, backup and fresh restores, and rollback by restoring the pre-upgrade snapshot onto 1.20.6. The missing-key check runs on the fresh 1.22.0 install and on the 1.20.6 instance.node.sh check-bare-image-missing-key(called fromci.shon the fresh 1.22.0 instance): starts the 1.22.0 image as published, with no mounted config, key or environment, and requires exit 1 plus the node's exactMissing secretline. It shares its matcher withcheck-missing-key.node.sh check-versionalso fails if/versionlistsencryption-named-keys-v1orsql-delegated-caveats-v1, which are disabled by default in 1.22.0.deploy/personal-node/README.md: pins and CI description; the seven database migrations the upgrade applies (1.21.0: four, 1.21.3, 1.21.8, 1.21.9; none in 1.22.0); rollback is a restore of the pre-upgrade backup; named keys and delegated SQL caveats are disabled by default; images are pinned by digest.Scope
tinycloud.tomlis unchanged.Verification
CI jobs of the "Personal node guide" workflow:
published-images(runsci.sh),dstack-profile,dstack-config-source.bash -npasses onnode.shandci.sh, and the bare-image matcher was checked locally against a stand-indockercommand (no Docker daemon).Details: TC-1282