Add confirmed family members and reverse DNS details to relay dialog by JuliusHenke · Pull Request #465 · TorMap/tormap

JuliusHenke · 2026-05-01T13:05:18Z

Closes #451 with minor refactoring. @center2055 thanks a lot for your nice PR. Fixes #26.

Co-authored-by: @center2055

…ibrary Maintaining multi PTR response, while using a safer library for DNS resolving

# Conflicts: # backend/src/main/kotlin/org/tormap/adapter/controller/RelayDetailsController.kt # backend/src/main/kotlin/org/tormap/config/CacheConfig.kt

github-actions · 2026-05-01T13:06:51Z

Visit the preview URL for this PR (updated for commit fd74b50):

https://tormap-36f44--pr465-issue-26-relay-detai-lnjmdny2.web.app

_{(expires Sun, 31 May 2026 13:46:03 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 0c1f71965de18e60b0e686b0d0356977fec090dc}

Copilot

Pull request overview

Adds enriched relay details (confirmed family members + reverse DNS hostnames) to the relay details dialog, including backend lookup/caching and UI actions to display/select the confirmed family on the map.

Changes:

Backend: introduce reverse-DNS lookup service with caching and a query service that enriches relay details responses.
Backend API: switch relay details endpoint to return a dedicated DTO including confirmed family members + verified/unverified hostnames.
Frontend: extend DTO/types and render new relay dialog sections, including a “show confirmed family” action.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
frontend/src/dto/relay.ts	Extends relay details DTO with familyId + reverse DNS + confirmed family members; adjusts AS number typing.
frontend/src/components/dialogs/relay/RelayDetailsTable.tsx	Renders confirmed family members + reverse DNS sections and adds “show family on map” action.
frontend/src/components/dialogs/relay/RelayDetailsDialogSmall.tsx	Passes `closeDialog` into details table for post-action behavior.
frontend/src/components/dialogs/relay/RelayDetailsDialogLarge.tsx	Passes `closeDialog` into details table for post-action behavior.
frontend/src/components/buttons/SelectFamilyButton.tsx	Adds optional labeled (non-icon) button variant and reuses selection handler.
backend/src/test/kotlin/org/tormap/service/ReverseDnsLookupServiceTest.kt	Unit tests for verified vs unverified hostname separation and empty-result behavior.
backend/src/test/kotlin/org/tormap/service/RelayDetailsQueryServiceTest.kt	Unit tests for relay enrichment (family members + reverse DNS) and not-found behavior.
backend/src/test/kotlin/org/tormap/config/CacheConfigTest.kt	Ensures the new reverse DNS cache is created and cleared in tests.
backend/src/main/kotlin/org/tormap/service/ReverseDnsLookupService.kt	Implements reverse DNS lookup + forward-confirmation and caches results.
backend/src/main/kotlin/org/tormap/service/RelayDetailsQueryService.kt	Adds query service to assemble enriched relay details DTO from DB + reverse DNS.
backend/src/main/kotlin/org/tormap/config/CacheConfig.kt	Adds Ehcache config for reverse DNS lookup results with 6h TTL.
backend/src/main/kotlin/org/tormap/adapter/dto/RelayDetailsDto.kt	New DTO that exposes confirmed family members and reverse DNS hostnames.
backend/src/main/kotlin/org/tormap/adapter/controller/RelayDetailsController.kt	Switches relay details endpoint to return enriched DTO via query service.
backend/build.gradle.kts	Adds dnsjava dependency for reverse DNS lookups.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-05-01T13:10:20Z

+            InetAddress.getAllByName(hostName)
+                .filterNot { it.isPubliclyRoutable() }
+                .map { it.hostAddress }
+        } catch (_: UnknownHostException) {


lookupAddresses only catches UnknownHostException, but InetAddress.getAllByName (or the subsequent address processing) can still throw runtime exceptions (e.g., SecurityException, unexpected parsing issues). Since lookupHostNames doesn’t catch these, a single bad PTR hostname could cause a 500 for the relay-details endpoint. Consider catching a broader Exception here (as done in lookupPtrRecords) and returning emptyList() (optionally with a log at debug/warn level).

Suggested change

} catch (_: UnknownHostException) {

} catch (_: Exception) {

@copilot Implement this with a debug logger for exceptions on this and other parts of the service

Copilot · 2026-05-01T13:10:20Z

+    private fun InetAddress.isULA(): Boolean =
+        this is Inet6Address &&
+            (address[0].toInt() and 0xFE) == 0xFC  // fc00::/7
+
+    private fun InetAddress.isPubliclyRoutable(): Boolean =
+        isLoopbackAddress ||
+            isLinkLocalAddress ||
+            isSiteLocalAddress ||   // reliable for IPv4
+            isULA() ||              // fills the IPv6 gap isSiteLocalAddress misses
+            isMulticastAddress ||
+            isAnyLocalAddress ||
+            address.first() == 0.toByte() ||
+            (address.size == 4 &&
+                address[0] == 100.toByte() &&
+                (address[1].toInt() and 0xFF) in 64..127)
+}


The helper isPubliclyRoutable() currently returns true for addresses that are not publicly routable (loopback/link-local/site-local/ULA/multicast/CGNAT, etc.), and callers rely on this inversion via filterNot { it.isPubliclyRoutable() }. Renaming it to something like isNotPubliclyRoutable (or inverting the predicate and adjusting the filter) would make the intent clearer and reduce the risk of future misuse.

@copilot apply changes based on this feedback

Fixed in 646982c. Inverted the isPubliclyRoutable() predicate so it now correctly returns true for publicly routable addresses (negating all the non-routable conditions), and changed the call site from filterNot to filter to match.

Agent-Logs-Url: https://github.com/TorMap/tormap/sessions/6495a65b-9fc9-4868-b79c-08bdeb76ce17 Co-authored-by: JuliusHenke <23460202+JuliusHenke@users.noreply.github.com>

Copilot · 2026-05-01T13:18:02Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

collector.torproject.org
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Dorg.gradle.internal.worker.tmpdir=/home/REDACTED/work/tormap/tormap/backend/build/tmp/test/work @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath3845826778364404920txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 1' (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…Service Agent-Logs-Url: https://github.com/TorMap/tormap/sessions/b84c81e2-ed1f-4408-b992-7b703839ad93 Co-authored-by: JuliusHenke <23460202+JuliusHenke@users.noreply.github.com>

Agent-Logs-Url: https://github.com/TorMap/tormap/sessions/b84c81e2-ed1f-4408-b992-7b703839ad93 Co-authored-by: JuliusHenke <23460202+JuliusHenke@users.noreply.github.com>

Copilot · 2026-05-01T13:25:26Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

collector.torproject.org
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Dorg.gradle.internal.worker.tmpdir=/home/REDACTED/work/tormap/tormap/backend/build/tmp/test/work @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath6996109766756294891txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 1' (dns block)
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Dorg.gradle.internal.worker.tmpdir=/home/REDACTED/work/tormap/tormap/backend/build/tmp/test/work @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath14725746462298803059txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 2' (dns block)
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Dorg.gradle.internal.worker.tmpdir=/home/REDACTED/work/tormap/tormap/backend/build/tmp/test/work @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath2975394841889527095txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 3' (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…jection" This reverts commit d2bcddb.

Your Name and others added 6 commits March 18, 2026 08:47

Add relay family and reverse DNS details to dialog

ddade88

refactor(reverse-dns): replace JNDI based DNS resolver with dnsjava l…

d0a455c

…ibrary Maintaining multi PTR response, while using a safer library for DNS resolving

refactor(reverse-dns): prevent information disclosure via DNS rebinding

f489bdf

feat(reverse-dns): add cache TTL to ensure DNS freshness

4616bc4

Merge remote-tracking branch 'origin/master' into issue-26-relay-details

16d5ce7

# Conflicts: # backend/src/main/kotlin/org/tormap/adapter/controller/RelayDetailsController.kt # backend/src/main/kotlin/org/tormap/config/CacheConfig.kt

refactor(frontend): use RelayIdentifierDto consistently

398223e

Copilot AI review requested due to automatic review settings May 1, 2026 13:05

Copilot started reviewing on behalf of JuliusHenke May 1, 2026 13:05 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

chore: bump minor version for reverse DNS lookup feature

e877bb2

Copilot started work on behalf of JuliusHenke May 1, 2026 13:13 View session

fix: invert isPubliclyRoutable predicate and change filterNot to filter

646982c

Agent-Logs-Url: https://github.com/TorMap/tormap/sessions/6495a65b-9fc9-4868-b79c-08bdeb76ce17 Co-authored-by: JuliusHenke <23460202+JuliusHenke@users.noreply.github.com>

Copilot finished work on behalf of JuliusHenke May 1, 2026 13:18

Copilot started work on behalf of JuliusHenke May 1, 2026 13:18 View session

Copilot AI and others added 2 commits May 1, 2026 13:22

fix: add debug logger and broaden exception catch in ReverseDnsLookup…

4458c02

…Service Agent-Logs-Url: https://github.com/TorMap/tormap/sessions/b84c81e2-ed1f-4408-b992-7b703839ad93 Co-authored-by: JuliusHenke <23460202+JuliusHenke@users.noreply.github.com>

fix: sanitize external data in log messages to prevent log injection

d2bcddb

Agent-Logs-Url: https://github.com/TorMap/tormap/sessions/b84c81e2-ed1f-4408-b992-7b703839ad93 Co-authored-by: JuliusHenke <23460202+JuliusHenke@users.noreply.github.com>

Copilot finished work on behalf of JuliusHenke May 1, 2026 13:25

JuliusHenke added 2 commits May 1, 2026 15:42

Revert "fix: sanitize external data in log messages to prevent log in…

728d34f

…jection" This reverts commit d2bcddb.

fix: implement logger message sanitization on logback level

fd74b50

JuliusHenke merged commit 1632225 into master May 1, 2026
6 of 7 checks passed

JuliusHenke mentioned this pull request May 1, 2026

SQL transaction deadlock #269

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add confirmed family members and reverse DNS details to relay dialog#465

Add confirmed family members and reverse DNS details to relay dialog#465
JuliusHenke merged 12 commits intomasterfrom
issue-26-relay-details

JuliusHenke commented May 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 1, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 1, 2026

Uh oh!

JuliusHenke May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

JuliusHenke May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Copilot AI commented May 1, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI commented May 1, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

JuliusHenke commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

JuliusHenke May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

JuliusHenke May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 1, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI commented May 1, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JuliusHenke commented May 1, 2026 •

edited

Loading

github-actions Bot commented May 1, 2026 •

edited

Loading