fix(copilot): revert tool manifest version to v1 and restore verbatim AGPL text - #177
Merged
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| apps/tradinggoose/lib/copilot/runtime-tool-manifest.ts | Changes the externally transmitted manifest version literal from v2 to v1; no repository consumer requires v2, and the manifest shape is unchanged. |
| apps/tradinggoose/lib/copilot/runtime-tool-manifest.test.ts | Realigns the manifest unit test with the restored v1 runtime contract. |
Reviews (1): Last reviewed commit: "fix(copilot): revert tool manifest versi..." | Re-trigger Greptile
BruzWJ
marked this pull request as ready for review
July 27, 2026 19:34
TradingGoose-Dev
pushed a commit
that referenced
this pull request
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Puts the Copilot runtime tool manifest back on the
v1version literal the Copilot service accepts, and restoresLICENSEto the verbatim AGPL-3.0 text.COPILOT_RUNTIME_TOOL_MANIFEST_VERSIONinlib/copilot/runtime-tool-manifest.tsreturns to'v1', with a comment recording that it must matchTOOL_MANIFEST_VERSIONin the Copilot service, which validates the field as a strict literal and rejects the whole chat request on a mismatch.lib/copilot/runtime-tool-manifest.test.tsexpects'v1'again, which realigns it withapp/api/copilot/chat/review-session-post.test.ts— that suite assertstoolManifest.version === 'v1'in four places and has been failing onstagingsince the bump.LICENSE.No manifest shape changes. The Zod 4
z.toJSONSchemaemitter, the draft-7 tool parameter schemas, theedit_workflowgraph validators, and the droppedinstructions/workspaceIdfields all stay exactly as they are onstaging. Only the version string moves.Why
Manifest version. The manifest is sent to the external Copilot service as
toolManifestin the/api/copilotrequest payload (app/api/copilot/chat/route.ts:880). That service pins the version as a strict literal, sov2fails validation and the entire chat request is rejected — not a degraded tool list, the whole call. The bump tov2landed with the Zod 4 / graph-workflow manifest rewrite in #173 without a matching service-side release, so the version string is describing a handshake that does not exist yet. Reverting the literal restores Copilot chat while keeping every improvement from that rewrite.The stale route test is the corroborating signal:
review-session-post.test.tswas never updated tov2, sostagingcurrently ships a manifest the service rejects and a red test suite. Both come back green here.License. The AGPL-3.0 text states that verbatim copies may be distributed but "changing it is not allowed", so prepending a project header modifies the license document itself and also defeats automated license detection (GitHub/licensee matches the file against the canonical text). The attribution is not lost —
NOTICEalready carriesTradingGoose Studio / Copyright 2025-2026 TradingGoose Studioalong with the AGPL-3.0-only distribution statement, andREADME.md:186states the same.package.jsonstill declares"license": "AGPL-3.0-only". This only removes a duplicate that did not belong in the license text.Affected Areas
apps/tradinggooseapps/docspackages/*Issue Links( if any )
Follows up on #173, which bumped the manifest version.
Validation
Risk / Rollout Notes
Low risk, no schema or config changes, deploy normally.
v1. If av2-aware service release is already out or lands between now and merge, this revert is the wrong direction and the correct fix is to updatereview-session-post.test.tstov2instead. Worth confirming the deployed service version before merging.v2, this constant,runtime-tool-manifest.test.ts, and the four assertions inreview-session-post.test.tsall have to change in the same release.staging, so no tool behavior, parameter schema, or validator changes ship here.LICENSEis metadata only — no code, build, or runtime impact. Expect GitHub to start reporting the repository license as AGPL-3.0 rather than "Other".Config / Data Changes
toolManifest.version: 'v1'again, which is what it validates against — this is the fix, not a side effectScreenshots / Video
Checklist