Skip to content

Updated WebView library (the one being used is gonna be removed) and iOS error#96

Open
BernaLang wants to merge 3 commits into
TradingPal:masterfrom
BernaLang:master
Open

Updated WebView library (the one being used is gonna be removed) and iOS error#96
BernaLang wants to merge 3 commits into
TradingPal:masterfrom
BernaLang:master

Conversation

@BernaLang

Copy link
Copy Markdown

According to the React Native Docs the <WebView/> is going to be removed from React Native core and we should instead use react-native-community/react-native-webview.

@zeritte

zeritte commented Jun 21, 2019

Copy link
Copy Markdown

note that this has a problem with expo

@njt1982

njt1982 commented Jul 23, 2019

Copy link
Copy Markdown

I'm having issues adding this fork as I think the source package.json has an invalid semver version...

$ yarn add git+https://github.com/BernaLang/react-native-highcharts.git#86ce7bf
yarn add v1.16.0
[1/4] 🔍  Resolving packages...
error Can't add "react-native-highcharts": invalid package version "1.1".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

@BernaLang

Copy link
Copy Markdown
Author

I'm having issues adding this fork as I think the source package.json has an invalid semver version...

$ yarn add git+https://github.com/BernaLang/react-native-highcharts.git#86ce7bf
yarn add v1.16.0
[1/4] 🔍  Resolving packages...
error Can't add "react-native-highcharts": invalid package version "1.1".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

I changed the version, it should work now 😄

@BernaLang

Copy link
Copy Markdown
Author

note that this has a problem with expo

I don't really work with expo, could you tell me what the problem is?

@BernaLang BernaLang changed the title Updated WebView library (the one being used is gonna be removed) Updated WebView library (the one being used is gonna be removed) and iOS error Jul 23, 2019
@BernaLang

Copy link
Copy Markdown
Author

Added a new commit to fix a iOS error by whitelisting the file directory on the webview.

@rgordon95

Copy link
Copy Markdown

only error im getting in my testflight build is related to the deprecated webview from this package, any chance this will be merged soon?

@intruder09

Copy link
Copy Markdown

can you please update ASAP . since our app usage a lot of highcharts and in the latest release of react-native does not support webview from react-native . Please replace it with webview from react-native-webview

@flapotre

flapotre commented Sep 3, 2019

Copy link
Copy Markdown

Do you know when this pull request will be merge ? We need it to use it with react-native 0.59.

@redsharpie

Copy link
Copy Markdown

Please accept the pull request so we can update our application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants