Claude/improve ars test runner gmv1y#42
Merged
Merged
Conversation
The previous performance runner tagged each poll request with the parent_pk as its name, so every query produced its own Locust stats row and the result collector silently overwrote rows as it iterated. It also fired a manual GET_RESPONSE event on top of the auto-tracked GET, which double-counted polls and made the headline "Number of Requests" number opaque. There was no metric for end-to-end query completion time or for how many queries actually finished. Reshape ARSUser (and ARAUser, mirrored) into three explicit layers: - POST submit_query for submission stats - GET poll_status for polling stats (one shared name, no per-pk) - A custom QUERY event fired exactly once per query in a try/finally, with response_time set to wall time from submit to terminal state and the name encoding the outcome: completed, errored, polling_failed, timed_out, or abandoned. Cap the poll deadline at test_run_time and convert GreenletExit during the poll loop into an "abandoned" record so we can count in-flight queries when the runner shuts down. Rewrite collect_performance_result to consume this layered shape without overwriting rows, and rewrite dump_result_summary to emit per-outcome counts, completed-throughput, and avg/median/p95/min/max both for completed-only queries and across all outcomes, plus separate submit and poll request stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.