add new value to ServiceConditionEnumeration#193
Merged
Conversation
haeckerbaer
requested review from
Aurige,
SteffenSuhr,
TuThoThai,
Ulf9,
skinkie,
tim-rivett and
ue71603
haeckerbaer
added
enhancement
* Clarification of the annotation * Adding '+v2.3' to identify that it is a new value
Contributor
|
in SIRI FM, we have a more detailed description: |
Clarifying that the MobilityImpaired boolean value should reflect the overall summary of the AccessibilityAssessment of the StopPoint, when available.
TuThoThai
previously approved these changes
Apr 21, 2026
thbar
previously approved these changes
Apr 22, 2026
thbar
left a comment
thbar
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I've proposed a typo fix.
typo in the documentation Co-authored-by: Thibaut Barrère <thibaut.barrere@gmail.com>
TuThoThai
approved these changes
Apr 22, 2026
SteffenSuhr
approved these changes
May 13, 2026
SteffenSuhr
left a comment
SteffenSuhr
left a comment
Collaborator
There was a problem hiding this comment.
According to the Cologne Public Transportation Authority (and to me), that's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's no appropriate value for Condition (within PtSituationElement.Consequence as part of an SX message) in case the AccessibilityAssessment, for example of an AffectedStopPoint, is updated as a consequence of a situation.