harmonize type of VehicleMode in services pt, et, vm, st, sm#207
Open
haeckerbaer wants to merge 3 commits into
Open
harmonize type of VehicleMode in services pt, et, vm, st, sm#207haeckerbaer wants to merge 3 commits into
haeckerbaer wants to merge 3 commits into
Conversation
haeckerbaer
requested review from
Aurige,
BredeD,
DohmenClaus,
TuThoThai,
Ulf9,
skinkie,
thbar,
tim-rivett and
ue71603
haeckerbaer
added
enhancement
ue71603
previously approved these changes
May 13, 2026
Collaborator
|
Will be in 2.3 if Tu-Tho manages to check the examples, otherwise will be moved to 3.0 |
Collaborator
Author
|
in all of the subdirectories of /examples only a single file contains the VehicleMode element: /siri_exm_SX/exx_situationExchange_request.xml and the value is 'rail' which is still valid. So from my perspective this change does not impact the examples at all and can savely be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though VehicleModesOfTransportEnumeration was updated in v2.1, all services still seem to use an independent / custom type defnition that wasn't updated! This results in new vehicle modes that cannot actually be used for example in ET.
The CR will replace the old (non updated) VehicleModesEnumeration definition (in the siri_reference schema) with the originally intended and in v2.1 updated VehicleModesOfTransportEnumeration definition (in schema siri_modes).