Adding PublicationRef and ConsequenceCode#209
Open
TuThoThai wants to merge 3 commits into
Open
Conversation
Need: Data consumers want to track the ParametrisedAction of one or several Consequences Change: - Adding `PublicationRef` to identify a `ParametrisedAction` for easier updates on data consumers side - Adding `ConsequenceRef` in `ParametrisedAction` to strenghten the link between the Consequence of a Situation and its publication - Adding `ConsequenceCode` in `PtConsequence` as a unique identifier of the Consequence that can be referrenced elsewhere
skinkie
reviewed
Apr 22, 2026
Contributor
|
I don't understand the need. For now -1. |
Collaborator
Author
We discussed it at the previous SIRI-SX task force meeting. Let me detail the context to better reflect what was presented. 😊 ==> Change done at the beginning of the PR |
Collaborator
Author
|
On 22 April, discussions
|
haeckerbaer
requested changes
May 13, 2026
haeckerbaer
left a comment
Collaborator
There was a problem hiding this comment.
Please add an example that details in what scenarios these new references can/should be used (as already discussed in the SX task force). Otherwise approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request primarily made by the French mirror group.
Context
What is happening in real life:
On the data consumers' side:
Hence, the double need:
Change request
PublicationRefto identify aParametrisedActionfor easier updates on data consumers sideConsequenceRefinParametrisedActionto strenghten the link between the Consequence of a Situation and its publicationConsequenceCodeinPtConsequenceas a unique identifier of the Consequence that can be referrenced elsewhereThis request for change was discussed on 7 Apil 2026 in the SIRI-SX task force with positive outcome.