Skip to content

chore(tests): keep maintained coverage independent of TCP - #493

Open
yordis wants to merge 1 commit into
yordis/chore-migrate-projection-tests-grpcfrom
yordis/chore-migrate-core-tests-grpc
Open

chore(tests): keep maintained coverage independent of TCP#493
yordis wants to merge 1 commit into
yordis/chore-migrate-projection-tests-grpcfrom
yordis/chore-migrate-core-tests-grpc

Conversation

@yordis

@yordis yordis commented Sep 12, 2026

Copy link
Copy Markdown
Member
  • Preserves maintained core coverage on the supported client path.

@yordis
yordis requested a review from a team as a code owner September 12, 2026 23:21
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to test projects and fixtures; production behavior is touched only indirectly via updated legacy authorization test expectations for removed TCP statistics access.

Overview
Migrates core test coverage off the legacy TCP/EventStore.ClientAPI path onto HTTPS/gRPC (EventStore.Client.Streams) and shared HTTP helpers, so maintained tests no longer depend on TCP readiness or TestConnection.

Adds TestCertificates (runtime-generated CA/server certs) and replaces ssl_connections usage in updated fixtures. Test setup drops WaitForTcpEndPoint / TCP client reconnect loops in favor of node start (and gRPC health where needed). MiniNode restarts in truncation tests now key only on HTTP port.

Removes or rewrites TCP-centric cases: follower auth via TCP, ignored persistent-subscription deadlock test, legacy policy expectation for Operations.Node.Statistics.Tcp, and cluster/options assertions for internal/external TCP advertise endpoints and TCP plugin config in startup_should.

Test API cleanups: ExpectedVersion and utils references point at EventStore.Core.Data / EventStore.Common.Utils; AllReader/filter tests use EventFilter.* factories instead of client Filter messages; enumerator/scavenge/transform suites use a shared gRPC Append/Read harness; a few gRPC metadata payloads use raw JSON instead of StreamMetadata client helpers.

Reviewed by Cursor Bugbot for commit a9a13e7. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c0089263-28fc-4a98-becb-5c41a2710747

📥 Commits

Reviewing files that changed from the base of the PR and between 01d8da6 and a9a13e7.

📒 Files selected for processing (32)
  • src/EventStore.Core.Tests/Authorization/LegacyPolicyVerification.cs
  • src/EventStore.Core.Tests/ClientOperations/specification_with_bare_vnode.cs
  • src/EventStore.Core.Tests/ClientOperations/when_committing_a_transaction_with_data.cs
  • src/EventStore.Core.Tests/Helpers/TestCertificates.cs
  • src/EventStore.Core.Tests/Helpers/TestFixtureWithExistingEvents.cs
  • src/EventStore.Core.Tests/Http/HealthChecks/when_performing_a_live_check.cs
  • src/EventStore.Core.Tests/Integration/authenticated_requests_made_from_a_follower.cs
  • src/EventStore.Core.Tests/Integration/specification_with_a_single_node.cs
  • src/EventStore.Core.Tests/Integration/when_a_single_node_is_restarted_multiple_times.cs
  • src/EventStore.Core.Tests/Services/PersistentSubscription/PersistentSubscriptionTests.cs
  • src/EventStore.Core.Tests/Services/Replication/LeaderReplication/when_replica_subscribes.cs
  • src/EventStore.Core.Tests/Services/RequestManagement/Service/RequestManagerServiceSpecification.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_all_with_disallowed_streams.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_all_with_filtering.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_hash_collisions.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_running_a_scavenge_from_storage_scavenger.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.AllSubscription.CombinationTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.AllSubscriptionFiltered.CombinationTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.CombinationTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.StreamSubscription.CombinationTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/DeleteTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/ReadStreamsForwardTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Http/Authorization/authorization_tests.cs
  • src/EventStore.Core.Tests/Services/UserManagementService/user_management_service.cs
  • src/EventStore.Core.Tests/Services/VNode/startup_should.cs
  • src/EventStore.Core.Tests/TransactionLog/Truncation/when_truncating_database.cs
  • src/EventStore.Core.Tests/Transforms/TransformTests.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/ClusterVNodeOptionsScenarios.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_cluster_node_and_custom_settings.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_single_node_and_custom_settings.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_tls.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_shutting_down_an_isolated_cluster_member.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis added this pull request to stack #500 September 12, 2026 23:22

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bf237a2. Configure here.

@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch from bf237a2 to 87a926e Compare September 13, 2026 00:15
@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch 2 times, most recently from 104f85f to eb369f6 Compare September 13, 2026 00:58
@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch 2 times, most recently from 0339e19 to a8d6a9b Compare September 13, 2026 01:31
@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch 2 times, most recently from d770071 to ed044dd Compare September 13, 2026 02:04
@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch from ed044dd to 94936ff Compare September 13, 2026 02:29
@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch 2 times, most recently from 6912f13 to a8f30b3 Compare September 13, 2026 03:14
@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch from a8f30b3 to 7b55ead Compare September 13, 2026 03:46
@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch from 7b55ead to 5fe12cd Compare September 13, 2026 04:23
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/chore-migrate-core-tests-grpc branch from 5fe12cd to a9a13e7 Compare September 13, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant