Skip to content

chore(tests): retire obsolete TCP integration fixtures - #494

Open
yordis wants to merge 1 commit into
yordis/chore-migrate-core-tests-grpcfrom
yordis/chore-retire-core-tcp-tests
Open

chore(tests): retire obsolete TCP integration fixtures#494
yordis wants to merge 1 commit into
yordis/chore-migrate-core-tests-grpcfrom
yordis/chore-retire-core-tcp-tests

Conversation

@yordis

@yordis yordis commented Sep 12, 2026

Copy link
Copy Markdown
Member
  • Removes integration fixtures that only exercised the retired transport.

@yordis
yordis requested a review from a team as a code owner September 12, 2026 23:22
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only deletions with no runtime code changes; main risk is reduced regression coverage for retired TCP paths and for stream metadata copying.

Overview
Deletes a batch of EventStore.Core.Tests fixtures tied to the retired TCP client transport and related cluster/TCP scenarios, aligning the test suite with transports that are still supported.

Removed coverage includes TCP dispatcher behavior for v2 clients (deleted streams, subscriptions, scavenge responses), TcpConnectionManager (trusted writes, pending-send and queue limits), plain and SSL TcpConnection lifecycle tests, invalid TCP payload integration checks, and intermediate certificate handshake tests. Also drops the long-running when_node_becomes_leader_with_unindexed_data cluster integration fixture.

The diff also removes copying_metadata, which exercised StreamMetadata.Copy() via the Client API and is not TCP-specific, so that behavior is no longer covered in this project unless tests live elsewhere.

Reviewed by Cursor Bugbot for commit 2c805a1. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 526bb280-14d8-4cb1-9c9e-c9ce35386a86

📥 Commits

Reviewing files that changed from the base of the PR and between a9a13e7 and 2c805a1.

📒 Files selected for processing (8)
  • src/EventStore.Core.Tests/Integration/when_node_becomes_leader_with_unindexed_data.cs
  • src/EventStore.Core.Tests/Services/Transport/Tcp/TcpClientDispatcherTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionManagerTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionSslTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Tcp/when_invalid_data_is_sent_over_tcp.cs
  • src/EventStore.Core.Tests/Services/Transport/Tcp/with_intermediate_certificates.cs
  • src/EventStore.Core.Tests/copying_metadata.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis added this pull request to stack #500 September 12, 2026 23:22
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch 2 times, most recently from 76309a0 to 60eb376 Compare September 13, 2026 00:33
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from 60eb376 to 59514f1 Compare September 13, 2026 00:58
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from 59514f1 to 059ca6b Compare September 13, 2026 01:16
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from 059ca6b to 9cc1112 Compare September 13, 2026 01:31
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from 9cc1112 to 0e1e63e Compare September 13, 2026 01:46
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch 2 times, most recently from 104f2a6 to d45ae37 Compare September 13, 2026 02:29
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from d45ae37 to 9739ad5 Compare September 13, 2026 02:59
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from 9739ad5 to d499103 Compare September 13, 2026 03:14
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from d499103 to d5dc2ee Compare September 13, 2026 03:46
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from d5dc2ee to 183d819 Compare September 13, 2026 04:23
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/chore-retire-core-tcp-tests branch from 183d819 to 2c805a1 Compare September 13, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant