Skip to content

chore(transport): retire the legacy TCP package - #498

Open
yordis wants to merge 1 commit into
yordis/feat-grpc-connection-observabilityfrom
yordis/chore-remove-legacy-tcp-package
Open

chore(transport): retire the legacy TCP package#498
yordis wants to merge 1 commit into
yordis/feat-grpc-connection-observabilityfrom
yordis/chore-remove-legacy-tcp-package

Conversation

@yordis

@yordis yordis commented Sep 12, 2026

Copy link
Copy Markdown
Member
  • Prevents the retired transport from remaining buildable or distributable by accident.

@yordis
yordis requested a review from a team as a code owner September 12, 2026 23:22
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Large deletion of networking transport code; risk is mainly if any external or undocumented consumers still referenced the project—in-repo references appear gone.

Overview
Removes the legacy EventStore.Transport.Tcp project from the solution and deletes its implementation (TCP/SSL connections, length-prefix framing, formatters, listeners, and monitoring).

Build hygiene: Drops the project from EventStore.sln (including all platform build mappings) and removes the central EventStore.Client package version from Directory.Packages.props, so the retired transport cannot be built or pulled in accidentally.

Reviewed by Cursor Bugbot for commit 39a8db8. Bugbot is set up for automated code reviews on this repo. Configure here.

@yordis
yordis added this pull request to stack #500 September 12, 2026 23:22
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 61a5de91-1e9a-4618-b463-3d562fa0cf4d

📥 Commits

Reviewing files that changed from the base of the PR and between ab718f7 and 2b3ea9b.

📒 Files selected for processing (23)
  • src/Directory.Packages.props
  • src/EventStore.Transport.Tcp/EventStore.Transport.Tcp.csproj
  • src/EventStore.Transport.Tcp/Formatting/FormatterBase.cs
  • src/EventStore.Transport.Tcp/Formatting/IMessageFormatter.cs
  • src/EventStore.Transport.Tcp/Formatting/RawMessageFormatter.cs
  • src/EventStore.Transport.Tcp/Framing/IMessageFramer.cs
  • src/EventStore.Transport.Tcp/Framing/LengthPrefixMessageFramer.cs
  • src/EventStore.Transport.Tcp/Framing/LengthPrefixMessageFramerWithBufferPool.cs
  • src/EventStore.Transport.Tcp/Framing/PackageFramingException.cs
  • src/EventStore.Transport.Tcp/Helper.cs
  • src/EventStore.Transport.Tcp/IMonitoredTcpConnection.cs
  • src/EventStore.Transport.Tcp/ITcpConnection.cs
  • src/EventStore.Transport.Tcp/SocketArgsPool.cs
  • src/EventStore.Transport.Tcp/TcpClientConnector.cs
  • src/EventStore.Transport.Tcp/TcpConfiguration.cs
  • src/EventStore.Transport.Tcp/TcpConnection.cs
  • src/EventStore.Transport.Tcp/TcpConnectionBase.cs
  • src/EventStore.Transport.Tcp/TcpConnectionMonitor.cs
  • src/EventStore.Transport.Tcp/TcpConnectionSsl.cs
  • src/EventStore.Transport.Tcp/TcpServerListener.cs
  • src/EventStore.Transport.Tcp/TcpStats.cs
  • src/EventStore.Transport.Tcp/TcpTypedConnection.cs
  • src/EventStore.sln
💤 Files with no reviewable changes (23)
  • src/EventStore.Transport.Tcp/Formatting/RawMessageFormatter.cs
  • src/EventStore.Transport.Tcp/Framing/LengthPrefixMessageFramerWithBufferPool.cs
  • src/EventStore.Transport.Tcp/EventStore.Transport.Tcp.csproj
  • src/EventStore.Transport.Tcp/TcpTypedConnection.cs
  • src/EventStore.Transport.Tcp/TcpConnection.cs
  • src/EventStore.Transport.Tcp/TcpConnectionSsl.cs
  • src/EventStore.Transport.Tcp/TcpServerListener.cs
  • src/EventStore.Transport.Tcp/TcpConfiguration.cs
  • src/EventStore.sln
  • src/EventStore.Transport.Tcp/IMonitoredTcpConnection.cs
  • src/EventStore.Transport.Tcp/Framing/IMessageFramer.cs
  • src/EventStore.Transport.Tcp/Framing/PackageFramingException.cs
  • src/EventStore.Transport.Tcp/TcpConnectionBase.cs
  • src/EventStore.Transport.Tcp/ITcpConnection.cs
  • src/EventStore.Transport.Tcp/TcpClientConnector.cs
  • src/EventStore.Transport.Tcp/SocketArgsPool.cs
  • src/EventStore.Transport.Tcp/TcpStats.cs
  • src/EventStore.Transport.Tcp/Formatting/FormatterBase.cs
  • src/EventStore.Transport.Tcp/Framing/LengthPrefixMessageFramer.cs
  • src/Directory.Packages.props
  • src/EventStore.Transport.Tcp/Formatting/IMessageFormatter.cs
  • src/EventStore.Transport.Tcp/TcpConnectionMonitor.cs
  • src/EventStore.Transport.Tcp/Helper.cs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pull request removes the EventStore.Transport.Tcp project and all its formatting, framing, connection, listener, SSL, pooling, configuration, monitoring, and statistics code. It also removes the project from the solution and removes one central package version entry.

Changes

TCP transport removal

Layer / File(s) Summary
Project and solution removal
src/Directory.Packages.props, src/EventStore.Transport.Tcp/EventStore.Transport.Tcp.csproj, src/EventStore.sln
The EventStore.Transport.Tcp project and its solution configuration entries are removed. The central EventStore.Client version entry is also removed.
Formatting and framing removal
src/EventStore.Transport.Tcp/Formatting/*, src/EventStore.Transport.Tcp/Framing/*
Formatter interfaces and implementations, length-prefix framers, and PackageFramingException are deleted.
Connection and monitoring removal
src/EventStore.Transport.Tcp/ITcpConnection.cs, src/EventStore.Transport.Tcp/IMonitoredTcpConnection.cs, src/EventStore.Transport.Tcp/Tcp*.cs, src/EventStore.Transport.Tcp/SocketArgsPool.cs, src/EventStore.Transport.Tcp/Helper.cs
TCP and SSL connections, client and server socket handling, pooling, configuration, monitoring, statistics, helper methods, and typed connection wrapping are deleted.

Priority: ⬇️ Low

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2b3ea

The removed transport project has no remaining tracked project, restore, packaging, or compilation references. No confirmed merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: retirement of the legacy TCP transport package.
Description check ✅ Passed The description accurately states that the changes prevent the retired transport from remaining buildable or distributable.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-remove-legacy-tcp-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from eb57a53 to aecb79b Compare September 13, 2026 00:33
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from aecb79b to 6c8c952 Compare September 13, 2026 00:58
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from b59fac7 to e2ed620 Compare September 13, 2026 01:31
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from e2ed620 to 75e1a84 Compare September 13, 2026 01:46
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 75e1a84 to 2b3ea9b Compare September 13, 2026 02:04
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 2b3ea9b to 55dbee6 Compare September 13, 2026 02:29
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 55dbee6 to 1a6764d Compare September 13, 2026 02:59
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from bc7052f to bc1674b Compare September 13, 2026 03:46
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from bc1674b to a6da954 Compare September 13, 2026 04:23
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from a6da954 to e255edb Compare September 13, 2026 06:04
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from e255edb to 38edb52 Compare September 13, 2026 18:21
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 38edb52 to 39a8db8 Compare September 13, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant