Skip to content

chore(docs): clarify the supported gRPC network boundary - #499

Open
yordis wants to merge 1 commit into
yordis/chore-remove-legacy-tcp-packagefrom
yordis/chore-document-grpc-networking
Open

chore(docs): clarify the supported gRPC network boundary#499
yordis wants to merge 1 commit into
yordis/chore-remove-legacy-tcp-packagefrom
yordis/chore-document-grpc-networking

Conversation

@yordis

@yordis yordis commented Sep 12, 2026

Copy link
Copy Markdown
Member
  • Keeps deployment, operator, and migration guidance aligned with the supported network topology and honest TestClient capabilities.

@yordis
yordis requested a review from a team as a code owner September 12, 2026 23:22
@yordis
yordis added this pull request to stack #500 September 12, 2026 23:22
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are mostly documentation and sample/CI configuration; operational impact is limited to operators who still rely on undocumented TCP settings or old monitoring RPC names.

Overview
This PR reframes TrogonEventStore’s supported network model across docs and sample deployments: gRPC on the node HTTP(S) endpoint for clients, gossip, elections, and follower-to-leader forwarding; gRPC on a dedicated replication HTTP(S) listener for node-to-node replication; and explicit removal of the legacy EventStore TCP client listener and TCP replication narrative from operator guidance.

Documentation updates span architecture, networking, cluster, security, installation, upgrade, Admin UI, and diagnostics—including Monitoring.ConnectionStats / Monitoring.ReplicationStats (replacing TCP-oriented stats), retired TestClient commands, and ReplicationPortAdvertiseAs vs deprecated TCP advertise settings.

Deployment/CI tweaks set EVENTSTORE_NODE_IP on local cluster compose files, adjust the runtime image EXPOSE ports, drop TCP test CA installation from the test Docker stage, trim .gitignore for a removed ClientAPI assembly path, and stop selecting TCP plugin tests in scripts/test.sh (with a longer core-services timeout).

Reviewed by Cursor Bugbot for commit fb61886. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 706269ee-ecab-42ab-8c59-c626211b2b10

📥 Commits

Reviewing files that changed from the base of the PR and between e255edb and fb61886.

📒 Files selected for processing (15)
  • .gitignore
  • Dockerfile
  • docker-compose.yml
  • docs/README.md
  • docs/admin-ui.md
  • docs/architecture.md
  • docs/cluster.md
  • docs/diagnostics/README.md
  • docs/installation.md
  • docs/networking.md
  • docs/security.md
  • docs/upgrade-guide.md
  • docs/whatsnew.md
  • samples/server/docker-compose-cluster.yaml
  • scripts/test.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 844ddd1. Configure here.

Comment thread docker-compose.yml
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch 2 times, most recently from e64b0cd to f4615e2 Compare September 13, 2026 00:33
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from f4615e2 to bf1b1ee Compare September 13, 2026 00:58
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from bf1b1ee to 6b3dfea Compare September 13, 2026 01:16
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 6b3dfea to edabfbe Compare September 13, 2026 01:31
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from edabfbe to 815e085 Compare September 13, 2026 01:46
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 815e085 to 4fc84c5 Compare September 13, 2026 02:04
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch 2 times, most recently from 523f6c0 to b247e43 Compare September 13, 2026 02:59
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from b247e43 to 8ab3833 Compare September 13, 2026 03:14
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 8ab3833 to 4c3d9cd Compare September 13, 2026 03:46
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 4c3d9cd to 103037b Compare September 13, 2026 04:23
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 103037b to fb61886 Compare September 13, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant