fix(deps): raise js-yaml past the advisory the previous pin held it below - #503
Conversation
…t below The existing override held js-yaml at a version the new advisory covers, so Dependabot had nothing it could raise. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview The v4 override moves from pinning Reviewed by Cursor Bugbot for commit ddefc49. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe workspace configuration adds a js-yaml 3.x override and updates the js-yaml 4.x override. Changesjs-yaml override updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The dependency update is limited to the intended js-yaml security patches and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the YAML lines Comment |
Two high severity
js-yamladvisories have been open againstdocs/pnpm-lock.yamlsince 13 September and Dependabot has not opened anything for them. That is not Dependabot being slow.docs/pnpm-workspace.yamlalready carried"js-yaml@>=4.0.0 <4.3.1": 4.3.1, added for an earlier advisory, and the new one covers< 4.3.2. The override was pinning the package to a version that is now itself vulnerable, so there was no update Dependabot was permitted to make. A security control that silences its own alerting is worth noticing.The 3.x copy, reached through
gray-matter, had no override at all and sat on 3.15.1 against an advisory covering< 3.15.2.Both ranges are now expressed against the patched versions rather than the previously patched ones. The resulting lockfile change is confined to
js-yaml: nothing else moved.The same shape applies to the other pinned ranges in that file,
postcss-selector-parsertwice over. They are correct against today's advisories, but they will fail the same quiet way if a future advisory extends past the pin, because an override that is exactly equal to the fixed version leaves no room for the next one.