Skip to content

chore(ci): gate every pull request, not only the ones aimed at main - #156

Merged
yordis merged 2 commits into
mainfrom
yordis/chore-ci-on-stacked-prs
Sep 13, 2026
Merged

chore(ci): gate every pull request, not only the ones aimed at main#156
yordis merged 2 commits into
mainfrom
yordis/chore-ci-on-stacked-prs

Conversation

@yordis

@yordis yordis commented Sep 13, 2026

Copy link
Copy Markdown
Member
  • A stacked pull request is aimed at its parent branch, not at main, and the base filter on pull_request meant CI never started for one. PRs fix(trg): carry a named grader's fields through the published report #152, feat(trg): support fixed mcp mocks with expectation guards #153 and feat(trg): let the llm judge target transcripts, files, and created-files lists #154 have run the title check, sign-off and nothing else: not Rustfmt, Clippy, tests, doc tests, the debug and release builds or the schema drift check.
  • The gap does not close by itself when the parent merges. GitHub retargets the base, but a base change is not one of the events that starts a workflow, so without a further push the code can reach main having never been gated.
  • Review had the same hole from the other side. reviews.auto_review.base_branches defaults to the default branch alone, so a stacked pull request reported "reviews are disabled for this base branch" and could reach approval with nobody having read it. A green check was never going to catch what review catches.
  • Every pull request is now gated and reviewable, whatever it is aimed at, which is the property worth having rather than a longer list of branch names that the next naming convention invalidates.

Filtering on the base branch meant a stacked pull request ran the title, sign-off and review
checks and none of the seven gates, so the work in a stack was only ever compiled and tested
after it had already been approved on the strength of checks that had not run. A base branch
changing when its parent merges does not raise an event that starts them either, so the gap
closed on merge rather than before it.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Sep 13, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Workflow trigger and bot config only; no application or security logic changes, with slightly more CI runs on PRs that previously skipped the Rust pipeline.

Overview
CI now runs on every pull request, not only those targeting main or develop. The pull_request.branches filter was removed from .github/workflows/ci.yml, so stacked PRs aimed at a parent branch get Rustfmt, Clippy, tests, builds, and schema checks the same as PRs to default branches.

A new .coderabbit.yaml turns on CodeRabbit auto_review for all base branches (".*"), matching that “gate every PR” behavior for reviews.

Reviewed by Cursor Bugbot for commit b71eefe. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 90f26334-1d8f-42f5-9352-e802c3951bc1

📥 Commits

Reviewing files that changed from the base of the PR and between dd3d8d3 and b71eefe.

📒 Files selected for processing (2)
  • .coderabbit.yaml
  • .github/workflows/ci.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Reviews were limited to the default branch, so a stacked pull request reported "reviews are
disabled for this base branch" and reached approval with nobody having read it. The gate added
alongside this covers the compiler and the tests; this covers the half of review that a green
check was never going to catch.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis merged commit cf8de58 into main Sep 13, 2026
12 checks passed
@yordis
yordis deleted the yordis/chore-ci-on-stacked-prs branch September 13, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant