chore(ci): gate every pull request, not only the ones aimed at main - #156
Conversation
Filtering on the base branch meant a stacked pull request ran the title, sign-off and review checks and none of the seven gates, so the work in a stack was only ever compiled and tested after it had already been approved on the strength of checks that had not run. A base branch changing when its parent merges does not raise an event that starts them either, so the gap closed on merge rather than before it. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview A new Reviewed by Cursor Bugbot for commit b71eefe. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviews were limited to the default branch, so a stacked pull request reported "reviews are disabled for this base branch" and reached approval with nobody having read it. The gate added alongside this covers the compiler and the tests; this covers the half of review that a green check was never going to catch. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
main, and the base filter onpull_requestmeant CI never started for one. PRs fix(trg): carry a named grader's fields through the published report #152, feat(trg): support fixed mcp mocks with expectation guards #153 and feat(trg): let the llm judge target transcripts, files, and created-files lists #154 have run the title check, sign-off and nothing else: not Rustfmt, Clippy, tests, doc tests, the debug and release builds or the schema drift check.mainhaving never been gated.reviews.auto_review.base_branchesdefaults to the default branch alone, so a stacked pull request reported "reviews are disabled for this base branch" and could reach approval with nobody having read it. A green check was never going to catch what review catches.