Repository navigation
feat(web): show the Watch Dog button in red when a pull request needs attention - #195
Conversation
PR SummaryLow Risk Overview All clear still uses Reviewed by Cursor Bugbot for commit 03cf7df. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Status-based button variant apps/web/src/components/pullRequest/PullRequestDetailActions.tsx |
The button uses destructive-outline for attention. The clear and other statuses retain secondary and outline, respectively. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Feature
Possibly related PRs
- TrogonStack/t3code#177: Adds
PullRequestWatchDogButtonand defines itsWatchDogStatusvalues.
Suggested labels: size:XS
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · previous review 03cf7
-
The attention state receives destructive-outline styling while other states retain their variants. No actionable merge-blocking issue is identified.
Pre-merge checks: 
3 · 
1
-
Failed checks: 1 warning Passed checks: 3 passedFull details: Description check
-
Explanation
The description includes all required sections and clearly explains the problem, change, scope, and automated verification. It does not include the required before/after screenshots for this UI change or running-client verification.
Resolution
Add clear before/after screenshots embedded or linked from GitHub. If possible, also perform and report a focused manual check in a running client.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
… attention Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
03cf7df to
314087a
Compare
Problem
The Watch Dog button looks the same whether a pull request has failing checks, unresolved threads, or requested changes, so a PR that needs work is easy to miss.
Change
The button uses the
destructive-outlinevariant when the watch dog status isattention. "All clear" keeps the secondary variant, and the pending and not-yet-loaded states keep the outline variant.Scope and approval
Small, focused visual tweak to an existing control: one variant choice in
PullRequestWatchDogButton.Verification
vp run check:changedpasses (format, lint, knip, typecheck, react compiler). I did not capture before/after screenshots or exercise it in a running client.