Skip to content

feat(web): show the Watch Dog button in red when a pull request needs attention - #195

Merged
yordis merged 1 commit into
mainfrom
yordis/feat-watch-dog-attention-red
Nov 2, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/feat-watch-dog-attention-red

Conversation

@yordis

@yordis yordis commented Nov 2, 2026

Copy link
Copy Markdown
Member

Problem

The Watch Dog button looks the same whether a pull request has failing checks, unresolved threads, or requested changes, so a PR that needs work is easy to miss.

Change

The button uses the destructive-outline variant when the watch dog status is attention. "All clear" keeps the secondary variant, and the pending and not-yet-loaded states keep the outline variant.

Scope and approval

Small, focused visual tweak to an existing control: one variant choice in PullRequestWatchDogButton.

Verification

vp run check:changed passes (format, lint, knip, typecheck, react compiler). I did not capture before/after screenshots or exercise it in a running client.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Nov 2, 2026
@cursor

cursor Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Single conditional styling change on an existing control; no logic, API, or data-handling changes.

Overview
The Watch Dog header button now uses the destructive-outline variant when watch-dog status is attention (failed checks, unresolved review threads, or change requests), so PRs that need work stand out visually.

All clear still uses secondary; pending, unknown, and loading states keep outline. Tooltip copy and click behavior are unchanged—only the button styling branches on status.

Reviewed by Cursor Bugbot for commit 03cf7df. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 03cf7df and 314087a.

Files selected for processing: 1
  • apps/web/src/components/pullRequest/PullRequestDetailActions.tsx

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 44e0549 and 03cf7df.

Files selected for processing: 1
  • apps/web/src/components/pullRequest/PullRequestDetailActions.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Watch Dog button now uses the destructive-outline variant for the attention status. The clear status uses secondary, and other statuses use outline.

Changes: Watch Dog button styling

Layer / File(s) Summary
Status-based button variant
apps/web/src/components/pullRequest/PullRequestDetailActions.tsx
The button uses destructive-outline for attention. The clear and other statuses retain secondary and outline, respectively.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Possibly related PRs

Suggested labels: size:XS

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review 03cf7

The attention state receives destructive-outline styling while other states retain their variants. No actionable merge-blocking issue is identified.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description includes all required sections and clearly explains the problem, change, scope, and automated verification. It does not include the required before/after screenshots for this UI change… Add clear before/after screenshots embedded or linked from GitHub. If possible, also perform and report a focused manual check in a running client.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: showing the Watch Dog button in red when a pull request needs attention.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes all required sections and clearly explains the problem, change, scope, and automated verification. It does not include the required before/after screenshots for this UI change or running-client verification.

Resolution

Add clear before/after screenshots embedded or linked from GitHub. If possible, also perform and report a focused manual check in a running client.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

… attention

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-watch-dog-attention-red branch from 03cf7df to 314087a Compare November 2, 2026 09:40
@yordis
yordis merged commit 5c2c5d5 into main Nov 2, 2026
9 checks passed
@yordis
yordis deleted the yordis/feat-watch-dog-attention-red branch November 2, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant