chore(proto): declare contract invariants as schema constraints - #568
Merged
Merged
Conversation
yordis
added this pull request to stack #569
September 12, 2026 04:08
PR SummaryMedium Risk Overview Across agents, session, and related protos, the diff imports CI/docs tooling extends ADR reference linting from proto-only to Reviewed by Cursor Bugbot for commit efd3ba9. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Important Review skippedToo many files! This PR contains 154 files, which is 54 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (154)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yordis
force-pushed
the
yordis/chore-proto-validate-annotations
branch
from
September 12, 2026 04:09
a56c1fa to
72ba053
Compare
yordis
force-pushed
the
yordis/chore-proto-validate-annotations
branch
from
September 12, 2026 04:10
72ba053 to
c621195
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 4 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c621195. Configure here.
Base automatically changed from
yordis/feat-agent-connection-declarations
to
main
September 12, 2026 04:35
yordis
force-pushed
the
yordis/chore-proto-validate-annotations
branch
from
September 12, 2026 04:35
c621195 to
0478766
Compare
The invariants these contracts depend on lived only in prose, where nothing could tell a true claim from a stale one. Declaring them as buf.validate constraints makes `buf lint` type-check them against the descriptor, so a restated invariant that no longer parses against the schema fails the build instead of quietly misleading a reader. ADR#0064 records why they stay unenforced for now and what enabling enforcement would cost. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/chore-proto-validate-annotations
branch
from
September 12, 2026 04:38
0478766 to
f02ae45
Compare
|
Code Coverage SummaryDetailsDiff against mainResults for commit: efd3ba9 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
… absent Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invariants these contracts depend on lived only in prose, where nothing
could tell a true claim from a stale one. Declaring them as buf.validate
constraints makes
buf linttype-check them against the descriptor, so arestated invariant that no longer parses against the schema fails the build
instead of quietly misleading a reader. ADR#0064 records why they stay
unenforced for now and what enabling enforcement would cost.
Signed-off-by: Yordis Prieto yordis.prieto@gmail.com
Stack created with GitHub Stacks CLI • Give Feedback 💬